Closed Bug 1440377 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 9635 - Move core CORB logic into //services/network.

Categories

(Testing :: web-platform-tests, enhancement, P3)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

Details

(Whiteboard: [wptsync downstream error])

Sync web-platform-tests PR 9635 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/9635
Details from upstream follow.

Lukasz Anforowicz wrote:
>  Move core CORB logic into //services/network.
>  
>  This CL moves the core CORB logic (figuring out if a given response
>  should be CORB-protected based on 1) response metadata like initiator,
>  MIME type, CORS headers and 2) sniffing the first bytes of the response)
>  from //content/common into //services/network.
>  
>  As part of the move, this CL makes some extra, opportunistic changes:
>  - Renames the moved files (and the moved class) to match the name agreed
>    upon in the explainer
>    (s/CrossSiteDocumentClassifier/CrossOriginReadBlocking)
>  - Also moves the explainer doc to //services/network
>  - Tweaks the old CrossSiteDocumentMimeType enum so that
>    - It is nested in CrossOriginReadBlocking::MimeType
>    - The enum values have shorter names
>  
>  In the long-term, the core CORB logic should only be needed within
>  services/network.  In the short-term, this logic has the following
>  consumers:
>  
>  - content/browser/loader/cross_site_document_resource_handler.cc
>    (integrates CORB into the old, pre-network-service,
>    ResourceHandler-based world;  this can go away after the network
>    service ships)
>  
>  - content/renderer/loader/site_isolation_stats_gatherer.cc
>    (gathers UMA that help decide what responses can be blocked
>    by CORB with acceptably low risk of breaking existing websites;
>    this can go away after CORB ships)
>  
>  - WIP(https://crbug.com/792546): services/network/url_loader.cc
>    (this will integrate CORB into the new, network-service world).
>  
>  Bug: 792546
>  Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
>  Change-Id: Ib8fe412b1f807d23e41700b7f7090cd4b77c1783
>  Reviewed-on: https://chromium-review.googlesource.com/929446
>  WPT-Export-Revision: fceabdf194f0fef2989fd201b64fa39b17750e4a
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/876b43bf2161
[wpt PR 9635] - Move core CORB logic into //services/network., a=testonly
https://hg.mozilla.org/mozilla-central/rev/876b43bf2161
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.