Closed Bug 1440384 Opened 2 years ago Closed 1 year ago

GenerateCombinedTransform probably doesn't want to run at the time it runs.

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

(Or if it does, it doesn't want to undo the work other people did).

In particular, we call it from ResolveSameStructsAs -> FinishStyle. That can run multiple times per element, there's no point of nulling it out at the beginning.

Though ideally we'd do the same as for backgrounds and stuff, and just run the code once we generate the computed values once:

  https://searchfox.org/mozilla-central/rev/9a8d3f8191b15cdca89a7ce044c7bea2dd0462dc/servo/components/style/properties/properties.mako.rs#3734
[Triage 2018/03/23 - P3]
Priority: -- → P3

That's all it does now. This will prevent other misuse and make it clearer.

Depends on D18567

Assignee: nobody → emilio
Blocks: 1418159
Blocks: 1525134
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/f63fef1c91c2
Generate combined transform just once. r=boris
https://hg.mozilla.org/integration/autoland/rev/eea42586757a
Rename FinishStyle to TriggerImageLoads. r=boris
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.