Closed Bug 1440393 Opened 5 years ago Closed 5 years ago

Move XBL accessibility role="xul:scale" and "xul:thumb" into XULMap.h

Categories

(Toolkit :: XUL Widgets, task)

Product:
Toolkit
Component:
XUL Widgets
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: timdream, Assigned: timdream)

References

Details

Attachments

(1 file)

Bug 1440393 - Move XBL accessibility role="xul:scale" and "xul:thumb" into XULMap.h
59 bytes, text/x-review-board-request
enndeakin
: review+
Details 
+++ This bug was initially created as a clone of Bug #1430777 +++

toolkit/content/widgets/scale.xml#scale role="xul:scale"
  scale
  toolkit/content/widgets/videocontrols.xml#suppressChangeEvent
    .scrubber
    .volumeControl

toolkit/content/widgets/scale.xml#scalethumb role="xul:thumb"
  .scale-thumb
Attachment #8953166 - Flags: review?(paolo.mozmail)
Attachment #8953166 - Flags: review?(enndeakin)
Comment on attachment 8953166 [details]
Bug 1440393 - Move XBL accessibility role="xul:scale" and "xul:thumb" into XULMap.h

https://reviewboard.mozilla.org/r/222442/#review229898

::: accessible/base/nsAccessibilityService.cpp:26
(Diff revision 3)
>  #include "HyperTextAccessibleWrap.h"
>  #include "RootAccessible.h"
>  #include "nsAccUtils.h"
>  #include "nsArrayUtils.h"
>  #include "nsAttrName.h"
> +#include "nsDOMTokenList.h"

This doesn't seem to be used.
Attachment #8953166 - Flags: review?(enndeakin) → review+
Comment on attachment 8953166 [details]
Bug 1440393 - Move XBL accessibility role="xul:scale" and "xul:thumb" into XULMap.h

https://reviewboard.mozilla.org/r/222442/#review230040

::: accessible/base/nsAccessibilityService.cpp:26
(Diff revision 3)
>  #include "HyperTextAccessibleWrap.h"
>  #include "RootAccessible.h"
>  #include "nsAccUtils.h"
>  #include "nsArrayUtils.h"
>  #include "nsAttrName.h"
> +#include "nsDOMTokenList.h"

Actually `ClassList()` returns a `nsDOMTokenList`.
Attachment #8953166 - Flags: review?(paolo.mozmail)
Pushed by timdream@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/294eefc61626
Move XBL accessibility role="xul:scale" and "xul:thumb" into XULMap.h r=enndeakin+6102
https://hg.mozilla.org/mozilla-central/rev/294eefc61626
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.