1440393 - Move XBL accessibility role="xul:scale" and "xul:thumb" into XULMap.h

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #1430777 +++

toolkit/content/widgets/scale.xml#scale role="xul:scale"
  scale
  toolkit/content/widgets/videocontrols.xml#suppressChangeEvent
    .scrubber
    .volumeControl

toolkit/content/widgets/scale.xml#scalethumb role="xul:thumb"
  .scale-thumb

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1440393 - Move XBL accessibility role="xul:scale" and "xul:thumb" into XULMap.h

Also removes the scalethumb binding as it had all its features replaced.

Review commit: https://reviewboard.mozilla.org/r/222442/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222442/

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8953166 [details]
Bug 1440393 - Move XBL accessibility role="xul:scale" and "xul:thumb" into XULMap.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222442/diff/1-2/

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8953166 [details]
Bug 1440393 - Move XBL accessibility role="xul:scale" and "xul:thumb" into XULMap.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222442/diff/2-3/

Comment 4

[Neil Deakin]

Comment on attachment 8953166 [details]
Bug 1440393 - Move XBL accessibility role="xul:scale" and "xul:thumb" into XULMap.h

https://reviewboard.mozilla.org/r/222442/#review229898

::: accessible/base/nsAccessibilityService.cpp:26
(Diff revision 3)
>  #include "HyperTextAccessibleWrap.h"
>  #include "RootAccessible.h"
>  #include "nsAccUtils.h"
>  #include "nsArrayUtils.h"
>  #include "nsAttrName.h"
> +#include "nsDOMTokenList.h"

This doesn't seem to be used.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8953166 [details]
Bug 1440393 - Move XBL accessibility role="xul:scale" and "xul:thumb" into XULMap.h

https://reviewboard.mozilla.org/r/222442/#review230040

::: accessible/base/nsAccessibilityService.cpp:26
(Diff revision 3)
>  #include "HyperTextAccessibleWrap.h"
>  #include "RootAccessible.h"
>  #include "nsAccUtils.h"
>  #include "nsArrayUtils.h"
>  #include "nsAttrName.h"
> +#include "nsDOMTokenList.h"

Actually `ClassList()` returns a `nsDOMTokenList`.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/294eefc61626
Move XBL accessibility role="xul:scale" and "xul:thumb" into XULMap.h r=enndeakin+6102

Comment 7

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/294eefc61626