Closed
Bug 1440417
Opened 6 years ago
Closed 6 years ago
Put the build system in charge of figuring out JS_64BIT
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: ehoogeveen, Assigned: ehoogeveen)
Details
Attachments
(1 file)
2.31 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Currently JS_64BIT is defined in jstypes.h [1] and its users rely on the fact that jstypes.h will always be included internally. This is true, but it seems somewhat unintuitive, and JS_64BIT can be defined much more simply by the build system. [1] https://searchfox.org/mozilla-central/source/js/src/jstypes.h#143
Assignee | ||
Comment 1•6 years ago
|
||
Simple patch. Nathan, you seemed like a good choice of reviewer since you did bug 1421687 :)
Attachment #8953169 -
Flags: review?(nfroyd)
Comment 2•6 years ago
|
||
Comment on attachment 8953169 [details] [diff] [review] Determine JS_64BIT at configure time. Review of attachment 8953169 [details] [diff] [review]: ----------------------------------------------------------------- WFM! Using HAVE_64BIT_BUILD would also be a reasonable approach.
Attachment #8953169 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 3•6 years ago
|
||
Thanks for the quick review! Looks like we also use HAVE_64BIT_BUILD in SM already but JS_64BIT is more common. Something to clarify at a later date perhaps; the definitions are identical. Some bustage on try but it looks preexisting: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8c6eebbf17c662f7941a8ee6e10ae1492a93997
Keywords: checkin-needed
Pushed by ccoroiu@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f2165bbee8a0 Determine JS_64BIT at configure time. r=froydnj
Keywords: checkin-needed
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f2165bbee8a0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•