1440417 - Put the build system in charge of figuring out JS_64BIT

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Emanuel Hoogeveen [:ehoogeveen]]

Currently JS_64BIT is defined in jstypes.h [1] and its users rely on the fact that jstypes.h will always be included internally. This is true, but it seems somewhat unintuitive, and JS_64BIT can be defined much more simply by the build system.

[1] https://searchfox.org/mozilla-central/source/js/src/jstypes.h#143

Comment 1

[Emanuel Hoogeveen [:ehoogeveen]]

Attachment: Determine JS_64BIT at configure time.

Simple patch. Nathan, you seemed like a good choice of reviewer since you did bug 1421687 :)

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8953169 [details] [diff] [review]
Determine JS_64BIT at configure time.

Review of attachment 8953169 [details] [diff] [review]:
-----------------------------------------------------------------

WFM!  Using HAVE_64BIT_BUILD would also be a reasonable approach.

Comment 3

[Emanuel Hoogeveen [:ehoogeveen]]

Thanks for the quick review! Looks like we also use HAVE_64BIT_BUILD in SM already but JS_64BIT is more common. Something to clarify at a later date perhaps; the definitions are identical.

Some bustage on try but it looks preexisting: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8c6eebbf17c662f7941a8ee6e10ae1492a93997

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2165bbee8a0
Determine JS_64BIT at configure time. r=froydnj

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/f2165bbee8a0