1440530 - Clean up some duplication in the webpayments mochitest-browser tests for setting up dialogs

Status: RESOLVED FIXED

(Firefox :: WebPayments UI, enhancement, P1)

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1440530 - Move dialog setup code out to a helper function for the webpayments mochitest-browser tests.

Review commit: https://reviewboard.mozilla.org/r/222584/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222584/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8953311 [details]
Bug 1440530 - Move dialog setup code out to a helper function for the webpayments mochitest-browser tests.

https://reviewboard.mozilla.org/r/222584/#review228514

Thanks

::: toolkit/components/payments/test/browser/head.js:152
(Diff revision 1)
>                                        (subject, data) => data == "add");
>    profileStorage.creditCards.add(PTU.BasicCards.JohnDoe);
>    await onChanged;
>  }
>  
> +async function setupPaymentDialog(browser, {methodData, details, options, taskFn}) {

It's not exactly clear where the `taskFn` will run (in the merchant tab or in the dialog?). Maybe rename to merchantTaskFn like `spawnInDialogForMerchantTask`.

A JSDoc comment like the other helpers would be useful too.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/624ce4190bce
Move dialog setup code out to a helper function for the webpayments mochitest-browser tests. r=mattn

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/624ce4190bce