Closed Bug 1440534 Opened 6 years ago Closed 6 years ago

Include source code for stack frames in JS error collection

Categories

(Firefox :: General, enhancement)

Product:
Firefox
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: osmose, Assigned: osmose)

References

Details

Attachments

(2 files)

Bug 1440534 Include source code in JS error reports.
45 bytes, text/x-phabricator-request
Gijs
: review+
Details | Review
Bug 1440534 Include source code in JS error reports.
45 bytes, text/x-phabricator-request
Gijs
: review+
Details | Review 
Turns out, Sentry supports sending the source code context for stack traces: https://docs.sentry.io/clientdev/interfaces/stacktrace/

We should include the source code when possible in stack traces sent to Sentry, as they provide really valuable context for investigating errors.
Comment on attachment 8953318 [details]
Bug 1440534 Include source code in JS error reports.

:Gijs has approved the revision.

https://phabricator.services.mozilla.com/D637
Attachment #8953318 - Flags: review+
Flags: in-testsuite+
Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2961b8217348
Backed out changeset c5e39b406004 for mochitest bc failures on browser_BrowserErrorReporter.js
Comment on attachment 8954197 [details]
Bug 1440534 Include source code in JS error reports.

:Gijs has approved the revision.

https://phabricator.services.mozilla.com/D648
Attachment #8954197 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/38fc9527e92a
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Depends on: 1445011
Depends on: 1445012
No longer depends on: 1445012
No longer depends on: 1445011
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: