Closed Bug 1440538 Opened 2 years ago Closed 2 years ago

Update Cubeb-rs to v0.4

Categories

(Core :: Audio/Video: cubeb, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: kamidphish, Assigned: kamidphish)

References

Details

Attachments

(5 files)

Update cubeb-rs, audioipc and cubeb-pulse-rs to use vendored version of cubeb-rs (v0.4.1)
Comment on attachment 8953326 [details]
Bug 1440538 - P1: Remove local cubeb-rs.

https://reviewboard.mozilla.org/r/222604/#review228494
Attachment #8953326 - Flags: review?(kinetik) → review+
Comment on attachment 8953327 [details]
Bug 1440538 - P2: Update audioipc to commit 933fb48.

https://reviewboard.mozilla.org/r/222606/#review228496
Attachment #8953327 - Flags: review?(kinetik) → review+
Comment on attachment 8953328 [details]
Bug 1440538 - P3: Update cubeb-pulse-rs update.sh.

https://reviewboard.mozilla.org/r/222608/#review228498
Attachment #8953328 - Flags: review?(kinetik) → review+
Comment on attachment 8953329 [details]
Bug 1440538 - P4: Update cubeb-pulse-rs to commit f58dc34.

https://reviewboard.mozilla.org/r/222610/#review228500
Attachment #8953329 - Flags: review?(kinetik) → review+
Comment on attachment 8953330 [details]
Bug 1440538 - P5: Vendor rust crates.

https://reviewboard.mozilla.org/r/222612/#review228688

r=me for the crate vendor, but I think you need to look at mda failures on the try push. Looks like a leak in cubeb.
Attachment #8953330 - Flags: review?(giles) → review+
Pushed by dglastonbury@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/34deadb4772f
P1: Remove local cubeb-rs. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/fb7e2f2bea09
P2: Update audioipc to commit 933fb48. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/6d9344794eb4
P3: Update cubeb-pulse-rs update.sh. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/765cdd7b0c46
P4: Update cubeb-pulse-rs to commit f58dc34. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/d798ddf4c17d
P5: Vendor rust crates. r=rillian
Rank: 15
Priority: -- → P2
(In reply to Ralph Giles (:rillian) | needinfo me from comment #10)
> Comment on attachment 8953330 [details]
> Bug 1440538 - P5: Vendor rust crates.
> 
> https://reviewboard.mozilla.org/r/222612/#review228688
> 
> r=me for the crate vendor, but I think you need to look at mda failures on
> the try push. Looks like a leak in cubeb.

Yeah, there was a leak. I've fixed that upstream in cubeb-rs, republished to crates-io and re-vendored.
Blocks: 1441591
Was cubeb supposed to be pulled once again?

We now have two copy of libcubeb in the tree and this new cubeb won't compiled if there's API difference with the first cubeb
Flags: needinfo?(dglastonbury)
That second cubeb is an artifact of the way rust crates work for putting up on crates.io. It shouldn't be compiled in. I tried to remove it from the package but that doesn't appear to be supported.

If you're having problems, do you have patches you can share so I can try locally.
Flags: needinfo?(dglastonbury) → needinfo?(jyavenard)
Depends on: 1442753
Flags: needinfo?(jyavenard)
You need to log in before you can comment on or make changes to this bug.