Closed Bug 1440559 Opened 4 years ago Closed 4 years ago

DataSourceSurfaceRecording allocates more data than necessary

Categories

(Core :: Graphics, defect)

56 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: lsalzman, Assigned: lsalzman)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

It allocates data using stride * height * bpp. It should just be stride * height.
Attachment #8953346 - Flags: review?(jmuizelaar)
Attachment #8953346 - Flags: review?(jmuizelaar) → review+
How'd you find this?
(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)
> How'd you find this?

Was poking around the code and merely noticed it.
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9140f4e82b3b
don't multiply DataSourceSurfaceRecording stride by bpp. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/9140f4e82b3b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.