DataSourceSurfaceRecording allocates more data than necessary

RESOLVED FIXED in Firefox 60

Status

()

defect
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: lsalzman, Assigned: lsalzman)

Tracking

56 Branch
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

Assignee

Description

a year ago
It allocates data using stride * height * bpp. It should just be stride * height.
Attachment #8953346 - Flags: review?(jmuizelaar)
Attachment #8953346 - Flags: review?(jmuizelaar) → review+
How'd you find this?
Assignee

Comment 2

a year ago
(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)
> How'd you find this?

Was poking around the code and merely noticed it.

Comment 3

a year ago
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9140f4e82b3b
don't multiply DataSourceSurfaceRecording stride by bpp. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/9140f4e82b3b
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.