Open Bug 1440588 Opened 2 years ago Updated 3 months ago

TLS session cache follow-up

Categories

(NSS :: Libraries, enhancement, P2)

3.35
enhancement

Tracking

(Not tracked)

People

(Reporter: franziskus, Unassigned)

References

Details

Attachments

(1 obsolete file)

Doing a try run on Firefox I noticed the following assert

> Assertion failure: sec->ci.sid->references == 1, at /builds/worker/workspace/build/src/security/nss/lib/ssl/sslnonce.c:1142

The assert itself is somewhat incorrect but there's a little more clean-up around it we should do. Unfortunately I can't reproduce the error locally.
Blocks: 1432177
See Also: → 1441095
Other assertions I've seen after fixing the first one.

>  Assertion failure: sid->creationTime != 0 && sid->expirationTime != 0, at /builds/worker/workspace/build/src/security/nss/lib/ssl/sslnonce.c:356 

> Assertion failure: sid->references >= 1, at /builds/worker/workspace/build/src/security/nss/lib/ssl/sslnonce.c:226
Comment on attachment 8953947 [details]
Bug 1440588 - don't try to free every SID and skip asserts that don't hold, r=mt

Kai Engert (:kaie:) has approved the revision.

https://phabricator.services.mozilla.com/D646
Attachment #8953947 - Flags: review+
no longer blocks the 3.36 release.
No longer blocks: 1432177
Target Milestone: 3.36 → ---
Priority: -- → P2
Attachment #8953947 - Attachment is obsolete: true
Assignee: franziskuskiefer → nobody
QA Contact: jjones
You need to log in before you can comment on or make changes to this bug.