Closed Bug 1440595 Opened 3 years ago Closed 3 years ago

Assertion failure: mSearchesOngoing > 0 && mSearches.Contains(aSearch) when using Tags autocomplete

Categories

(Firefox :: Bookmarks & History, defect, P2)

Product:
Firefox
Component:
Bookmarks & History
Version:
55 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: mak, Assigned: mak)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Bug 1440595 - Fix tags autocomplete assertions.
59 bytes, text/x-review-board-request
standard8
: review+
Details 
Tags autocomplete is just broken, the code should be rewritten in a more modern fashion, and the problem of returning results after the search has been stopped should be solved.
Summary: Assertion failure: mSearchesOngoing > 0 && mSearches.Contains(aSearch) when using Tags autocomplete → Fix tags autocomplete assertions
Summary: Fix tags autocomplete assertions → Assertion failure: mSearchesOngoing > 0 && mSearches.Contains(aSearch) when using Tags autocomplete
Note for the reviewer, this is not a priority, just cleanup.
Assignee: nobody → mak77
Blocks: 481451
Status: NEW → ASSIGNED
Comment on attachment 8954826 [details]
Bug 1440595 - Fix tags autocomplete assertions.

https://reviewboard.mozilla.org/r/223986/#review230946
Attachment #8954826 - Flags: review?(standard8) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/df0f95483846
Fix tags autocomplete assertions. r=standard8
https://hg.mozilla.org/mozilla-central/rev/df0f95483846
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.