1440599 - js/src/jit-test/tests/debug/bug1106719.js is going to permafail when Gecko 60 merges to Beta on 2018-03-01

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Nightly-as-Beta simulation (only the top 6 changesets belong to the simulation): https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7b3a15a3472b7167324cadafa4a2ffb2315c737&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable&selectedJob=163889525
It has bug 1435317 backed out because that caused bug 1440519.

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=163889525&repo=try

TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/debug/bug1106719.js | /builds/worker/workspace/build/src/js/src/jit-test/tests/debug/bug1106719.js:6:1 Error: attempt to set maxBytes to the value less than the current gcBytes (1294336) (code 3, args "--ion-eager --ion-offthread-compile=off")

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This didn't fail in the latest uplift sim: https://treeherder.mozilla.org/#/jobs?repo=try&revision=99a1d5c3a29ee1aedd591c0b79cb52db2c1c25d1&group_state=expanded&selectedJob=164205035&filter-searchStr=cgc

Comment 2

[Jon Coppeard (:jonco)]

There are a bunch of tests like this and they are pretty fragile.  We should do something about them.

Comment 3

[Jon Coppeard (:jonco)]

Attachment: bug1440599-remove-check

I think we should just remove this check.  It's part of the testing functions, not the product itself, and comparing against the current GC heap size is problematic already because it's an atomic field and is both incremented and decremented by helper threads.

If something sets the max heap size lower than the current size then there will be a failure at the next allocation.

What do you think?

Comment 4

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8954347 [details] [diff] [review]
bug1440599-remove-check

Review of attachment 8954347 [details] [diff] [review]:
-----------------------------------------------------------------

That's a straightforward way to fix a longstanding nuisance! You're right, we're not getting any use of the check and it's a pain in the posterior.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4abb98d61e99
Allow setting max GC heap size smaller than current size in the shell r=sfink

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4abb98d61e99