1440684 - 'mach robocop' busted: TypeError: grant_runtime_permissions() takes exactly 2 arguments (1 given)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, enhancement)

Description

[Geoff Brown [:gbrown]]

We missed one case when this was updated recently for geckoview support.


gbrown@mozpad:~/src$ ./mach robocop testAboutPage
Error running mach:

    ['robocop', 'testAboutPage']

The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command. Consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: grant_runtime_permissions() takes exactly 2 arguments (1 given)

  File "/home/gbrown/src/testing/mochitest/mach_commands.py", line 475, in run_robocop
    grant_runtime_permissions(self)

Comment 1

[Geoff Brown [:gbrown]]

Attachment: update grant_runtime_permissions call for 'mach robocop'

The other cases - mochitest and reftest - are okay.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8953457 [details] [diff] [review]
update grant_runtime_permissions call for 'mach robocop'

Review of attachment 8953457 [details] [diff] [review]:
-----------------------------------------------------------------

Whoops!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5fdaf6da588
Fix 'mach robocop' bustage for grant_runtime_permissions; r=snorp

Comment 4

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a5fdaf6da588