Closed
Bug 1440684
Opened 6 years ago
Closed 6 years ago
'mach robocop' busted: TypeError: grant_runtime_permissions() takes exactly 2 arguments (1 given)
Categories
(Firefox for Android Graveyard :: Testing, enhancement)
Firefox for Android Graveyard
Testing
Tracking
(firefox60 fixed)
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: gbrown, Assigned: gbrown)
Details
Attachments
(1 file)
1019 bytes,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
We missed one case when this was updated recently for geckoview support. gbrown@mozpad:~/src$ ./mach robocop testAboutPage Error running mach: ['robocop', 'testAboutPage'] The error occurred in the implementation of the invoked mach command. This should never occur and is likely a bug in the implementation of that command. Consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: TypeError: grant_runtime_permissions() takes exactly 2 arguments (1 given) File "/home/gbrown/src/testing/mochitest/mach_commands.py", line 475, in run_robocop grant_runtime_permissions(self)
Assignee | ||
Comment 1•6 years ago
|
||
The other cases - mochitest and reftest - are okay.
Attachment #8953457 -
Flags: review?(snorp)
Comment on attachment 8953457 [details] [diff] [review] update grant_runtime_permissions call for 'mach robocop' Review of attachment 8953457 [details] [diff] [review]: ----------------------------------------------------------------- Whoops!
Attachment #8953457 -
Flags: review?(snorp) → review+
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a5fdaf6da588 Fix 'mach robocop' bustage for grant_runtime_permissions; r=snorp
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a5fdaf6da588
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•