1440698 - Pushes with no jobs show "% - 0 in progress" rather than "Complete"

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P1)

Description

[Phil Ringnalda (:philor)]

STR: look at the top right of the push in https://treeherder.allizom.org/#/jobs?repo=mozilla-beta&revision=3df63b8f9bfaeedc47c149528584346910e47e91

Actual: "% - 0 in progress"

Expected: nobody expects the DONTBUILD push, its three main weapons are fear, surprise, and a fanatical devotion to dividing by zero.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3273

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 8954252 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3273

Left a comment :-)

Comment 3

[Cameron Dawson [:camd]]

I agree with your comment, I changed it so that it will be:

* be blank if total is 0
* show "{P}% - {N in-progress}" if it's less than 100, but the total is > 0
* show "- Complete -" if it's 100%.

Comment 4

[Ed Morley [:emorley]]

Comment on attachment 8954252 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3273

Perfect! :-)

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/706de914ee82aa9e2a34c51fa039fa6044fd5dae
Bug 1440698 - Fix push complete calculation