Closed Bug 1440702 Opened 4 years ago Closed 4 years ago

Add equality operators to Matrix4x4Flagged

Categories

(Core :: Graphics, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

Attachments

(1 file)

I need this for blob image invalidation
This adds a naive implementation of equality. We can do better in the future by looking at the flags.
Assignee: nobody → jmuizelaar
Attachment #8953484 - Flags: review?(bas)
Comment on attachment 8953484 [details] [diff] [review]
Add equality operators to Matrix4x4Flagged

Review of attachment 8953484 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/Matrix.h
@@ +2060,5 @@
>      return clone;
>    }
>  
> +  template <typename NewTargetUnits>
> +  bool operator==(const Matrix4x4TypedFlagged<TargetUnits, NewTargetUnits> &aMatrix) const

At least add a fast path for if both are IDENTITY! That's trivial :)
Attachment #8953484 - Flags: review?(bas) → review+
Blocks: 1388842
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c25484d9888
Add equality operators to Matrix4x4Flagged. r=Bas
https://hg.mozilla.org/mozilla-central/rev/7c25484d9888
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.