Closed
Bug 1440702
Opened 6 years ago
Closed 6 years ago
Add equality operators to Matrix4x4Flagged
Categories
(Core :: Graphics, enhancement, P3)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
Details
Attachments
(1 file)
|
1.80 KB,
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
I need this for blob image invalidation
|
Assignee | |
Comment 1•6 years ago
|
||
This adds a naive implementation of equality. We can do better in the future by looking at the flags.
Assignee: nobody → jmuizelaar
Attachment #8953484 -
Flags: review?(bas)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8953484 [details] [diff] [review] Add equality operators to Matrix4x4Flagged Review of attachment 8953484 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/2d/Matrix.h @@ +2060,5 @@ > return clone; > } > > + template <typename NewTargetUnits> > + bool operator==(const Matrix4x4TypedFlagged<TargetUnits, NewTargetUnits> &aMatrix) const At least add a fast path for if both are IDENTITY! That's trivial :)
Attachment #8953484 -
Flags: review?(bas) → review+
|
||
Updated•6 years ago
|
Priority: -- → P3
Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7c25484d9888 Add equality operators to Matrix4x4Flagged. r=Bas
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7c25484d9888
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•