1440727 - StructuredClone reader silently ignores extraneous bytes at the end

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Jason Orendorff [:jorendorff]]

This should be an error.

Rookie parser mistake. D'oh.

Comment 1

[Jason Orendorff [:jorendorff]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef5cd5673e15845054408bfe5650d0bb1a7280b8

Comment 2

[Jason Orendorff [:jorendorff]]

The SCTAG_TRANSFER_MAP_STORED_ARRAY_BUFFER code makes use of this, but we can afford to be a little stricter than we are currently, at least.

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1440727 - Disallow extra data at the end of serialized data buffer

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad9857e4fb96
Disallow extra data at the end of serialized data buffer r=decoder

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset ad9857e4fb96 (Bug 1440727) for causing build bustages in clone-errors.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=GTqVjCjKQPmPSXg9wl5M5g.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=ad9857e4fb96e72fa2c6b94f5c212dd1ce5a5e05

Log: https://treeherder.mozilla.org/logviewer?job_id=373558293&repo=autoland&lineNumber=56268

Backout: https://hg.mozilla.org/integration/autoland/rev/71c4fcb0b4be7e0014c888c2b2e32a9093a465c0

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1697fb86fbb2
Disallow extra data at the end of serialized data buffer r=decoder,jonco

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1697fb86fbb2