Open Bug 1440755 Opened 3 years ago Updated 3 years ago

[wpt-sync] Sync PR 9651 - Switch external_host to host_ip.

Categories

(Testing :: web-platform-tests, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: mozilla.org, Unassigned)

Details

(Whiteboard: [wptsync downstream error])

Sync web-platform-tests PR 9651 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/9651
Details from upstream follow.

jgraham wrote:
>  Switch external_host to host_ip.
>  
>  When running tests in Firefox we don't require that the hostname is
>  actually resolvable since we set up some internal DNS overrides. This
>  means that we don't actually need to have web-platform.test defined in
>  /etc/hosts. As a consequence when we check the server is responding,
>  the check will typically fail for Firefox developers if we try to
>  access by hostname. Previously we made use of a special dance in which
>  external_host held the ip at the point of the check and was later
>  replaced by host to actually run tests. But that changed, and instead
>  we relied on the fact that we (accidentially) didn't actually fail in
>  the case the servers couldn't be reached by host name. However in some
>  cases things still failed because local DNS resolved web-patform.test
>  to some ip address, causing hangs or other badness.
>  
>  In this patch we simply add a host_ip property to the config, and
>  connect to that to test the servers are repopnsing rather than the
>  hostname. We also actually fil if we didn't manage to connect to all
>  the servers.
Whiteboard: [wptsync downstream] → [wptsync downstream error]
You need to log in before you can comment on or make changes to this bug.