1440778 - Implement show-heartbeat action as an internal action

Status: RESOLVED FIXED

(Firefox :: Normandy Client, enhancement, P3)

Description

[Michael Cooper [:mythmon]]

This bug covers converting the show-heartbeat action [0] an internal action (see bug 1436129)

[0]: https://github.com/mozilla/normandy/tree/master/recipe-server/client/actions/show-heartbeat

Comment 1

[Peter Bengtsson [:peterbe]]

New URL for this is: https://github.com/mozilla/normandy/tree/master/client/actions/show-heartbeat

Comment 2

[Michael Cooper [:mythmon]]

Attachment: Bug 1440778 - Implement show-heartbeat as internal Normandy action r=Gijs

The original, server-side implementation of this action was at
https://github.com/mozilla/normandy/blob/68d3e55a9d8605bda793620640d074d7e5503e37/client/actions/show-heartbeat/index.js

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd482dcb9a31
Implement show-heartbeat as internal Normandy action r=Gijs

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for browser chrome failures on browser_EventEmitter.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=dd482dcb9a31815bd455ea07250ab9498d3664c0&group_state=expanded&selectedJob=214202251

Failure log: 
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=214202251&repo=autoland&lineNumber=6280
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=214200384&repo=autoland&lineNumber=1583

Backout link: https://hg.mozilla.org/integration/autoland/rev/efd37c2218442ac8c1ce23283f1907cccf64c548

Please also take a look over the TV failures. Thanks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24657145bfd4
Implement show-heartbeat as internal Normandy action r=Gijs

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/24657145bfd4

Comment 7

[Cristina Coroiu [:ccoroiu]]

Backed out changeset 24657145bfd4 (bug 1440778) on request by dev mythmon

Backout: https://hg.mozilla.org/integration/autoland/rev/5ee131dbcffba34ea868e7a26f443970520986d9

Comment 8

[Michael Cooper [:mythmon]]

Due to a combination of my not understanding the QA schedule and workflow, and delay caused by bug 1502410, this patch landed too late to receive proper testing. We've decided to back this patch out for now, and re-land it once mozilla-central bumps to version 66.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db84d5ee7e7a
Implement show-heartbeat as internal Normandy action r=Gijs

Comment 10

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/db84d5ee7e7a