Closed
Bug 1440778
Opened 3 years ago
Closed 2 years ago
Implement show-heartbeat action as an internal action
Categories
(Firefox :: Normandy Client, enhancement, P3)
Firefox
Normandy Client
Tracking
()
RESOLVED
FIXED
Firefox 66
People
(Reporter: mythmon, Assigned: mythmon)
References
Details
Attachments
(1 file)
This bug covers converting the show-heartbeat action [0] an internal action (see bug 1436129) [0]: https://github.com/mozilla/normandy/tree/master/recipe-server/client/actions/show-heartbeat
Comment 1•3 years ago
|
||
New URL for this is: https://github.com/mozilla/normandy/tree/master/client/actions/show-heartbeat
Assignee | ||
Updated•2 years ago
|
Assignee: nobody → mcooper
Assignee | ||
Comment 2•2 years ago
|
||
The original, server-side implementation of this action was at https://github.com/mozilla/normandy/blob/68d3e55a9d8605bda793620640d074d7e5503e37/client/actions/show-heartbeat/index.js
Pushed by mcooper@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dd482dcb9a31 Implement show-heartbeat as internal Normandy action r=Gijs
Comment 4•2 years ago
|
||
Backed out for browser chrome failures on browser_EventEmitter. Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=dd482dcb9a31815bd455ea07250ab9498d3664c0&group_state=expanded&selectedJob=214202251 Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=214202251&repo=autoland&lineNumber=6280 https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=214200384&repo=autoland&lineNumber=1583 Backout link: https://hg.mozilla.org/integration/autoland/rev/efd37c2218442ac8c1ce23283f1907cccf64c548 Please also take a look over the TV failures. Thanks.
Flags: needinfo?(mcooper)
Pushed by mcooper@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/24657145bfd4 Implement show-heartbeat as internal Normandy action r=Gijs
Comment 6•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/24657145bfd4
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Comment 7•2 years ago
|
||
Backed out changeset 24657145bfd4 (bug 1440778) on request by dev mythmon Backout: https://hg.mozilla.org/integration/autoland/rev/5ee131dbcffba34ea868e7a26f443970520986d9
Status: RESOLVED → REOPENED
status-firefox65:
fixed → ---
Resolution: FIXED → ---
Target Milestone: Firefox 65 → ---
Assignee | ||
Comment 8•2 years ago
|
||
Due to a combination of my not understanding the QA schedule and workflow, and delay caused by bug 1502410, this patch landed too late to receive proper testing. We've decided to back this patch out for now, and re-land it once mozilla-central bumps to version 66.
Flags: needinfo?(mcooper)
Assignee | ||
Updated•2 years ago
|
status-firefox60:
affected → ---
status-firefox65:
--- → wontfix
Pushed by mcooper@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/db84d5ee7e7a Implement show-heartbeat as internal Normandy action r=Gijs
![]() |
||
Comment 10•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/db84d5ee7e7a
Status: REOPENED → RESOLVED
Closed: 2 years ago → 2 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Updated•2 years ago
|
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•