1440810 - Deploy custom build of Mercurial 4.4 on hgweb

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, enhancement)

Description

[Gregory Szorc [:gps]]

We found an issue with Mercurial that will require a custom build of Mercurial 4.4 to fix. Goal is to get this build deployed next week.

Comment 1

[Gregory Szorc [:gps]]

Attachment: ansible/hg-web: fix typo in comment;

Review commit: https://reviewboard.mozilla.org/r/222910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222910/

Comment 2

[Gregory Szorc [:gps]]

Attachment: docker: copy untracked files from v-c-t/extra-files;

This adds files in the extra-files/ directory under v-c-t to the
Docker image build context. This makes it simpler to make one-off
changes to image building without checking things into version
control first.

Review commit: https://reviewboard.mozilla.org/r/222912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222912/

Comment 3

[Gregory Szorc [:gps]]

Attachment: ansible/hg-web: install custom build of Mercurial 4.4 (bug 1440810);

We want to use a custom build of Mercurial 4.4 for hgweb to work
around an upstream bug.

The source distribution is private. (A copy is currently on the
moz-packages S3 bucket but the object is private.) We copy the
source distribution from the extra-files/ directory of v-c-t to
/var/tmp/pip. The pip requirements file is taught to look in
/var/tmp/pip for files.

This will make it a little annoying to test hgweb. If you need to
test hgweb on top of this change, you can revert this changeset
easily enough. Alternatively, you could copy the mercurial-4.4.2.tar.gz
file to extra-files/ and change references to the filename and
hash. But this hack should be short enough lived and I don't
think many people will get tripped up by it. So I don't think there's
a need to code a workaround.

Review commit: https://reviewboard.mozilla.org/r/222914/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222914/

Comment 4

[Gregory Szorc [:gps]]

Attachment: ansible/hg-reviewboard: install custom build of Mercurial 4.4 (bug 1440810);

This is the same deal as the previous commit, except for reviewboard-hg.

Review commit: https://reviewboard.mozilla.org/r/222916/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222916/

Comment 5

[:glob ✱]

Comment on attachment 8953681 [details]
ansible/hg-web: fix typo in comment;

https://reviewboard.mozilla.org/r/222910/#review228944

Comment 6

[:glob ✱]

Comment on attachment 8953682 [details]
docker: copy untracked files from v-c-t/extra-files;

https://reviewboard.mozilla.org/r/222912/#review228948

::: testing/vcttesting/docker.py:288
(Diff revision 1)
>                  for f in fork_files:
>                      files.append(os.path.join('reviewboard-fork', f))
>  
> +        # Add untracked files from extra-files directory. This can be used
> +        # as a means to add files that aren't tracked by version control for
> +        # whatever reason.

extra-files should be added to .hgignore

Comment 7

[:glob ✱]

Comment on attachment 8953683 [details]
ansible/hg-web: install custom build of Mercurial 4.4 (bug 1440810);

https://reviewboard.mozilla.org/r/222914/#review228950

Comment 8

[:glob ✱]

Comment on attachment 8953684 [details]
ansible/hg-reviewboard: install custom build of Mercurial 4.4 (bug 1440810);

https://reviewboard.mozilla.org/r/222916/#review228952

Comment 9

[Gregory Szorc [:gps]]

Comment on attachment 8953681 [details]
ansible/hg-web: fix typo in comment;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222910/diff/1-2/

Comment 10

[Gregory Szorc [:gps]]

Comment on attachment 8953682 [details]
docker: copy untracked files from v-c-t/extra-files;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222912/diff/1-2/

Comment 11

[Gregory Szorc [:gps]]

Comment on attachment 8953683 [details]
ansible/hg-web: install custom build of Mercurial 4.4 (bug 1440810);

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222914/diff/1-2/

Comment 12

[Gregory Szorc [:gps]]

Comment on attachment 8953684 [details]
ansible/hg-reviewboard: install custom build of Mercurial 4.4 (bug 1440810);

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222916/diff/1-2/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/ca2291ae63ac
ansible/hg-web: install custom build of Mercurial 4.4 ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/39dec6132b69
ansible/hg-reviewboard: install custom build of Mercurial 4.4 ; r=glob