1440862 - Wording of Treeherder view for brand-new Try push has become less friendly

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect)

Description

[Botond Ballo [:botond]]

There is a brief period of time after pushing to Try when Treeherder does not yet know about the pushed revision.

If you open Treeherder to that revision during this period, it displays a message saying it doesn't know about that revision yet.

The wording of this message has recently changed. It's now:

  "This is an invalid or unknown revision. Please change it, or click here to reload the latest revisions from try."

Whereas it used to be something like (recalling from memory here):

  "This revision is not known yet. Please wait until it's loaded from the pushlog database."

In both cases, the page auto-refreshes when the revision appears and all is well. However, I think the older message was more friendly, as it makes clear you didn't do anything wrong and just need to wait.

Comment 1

[Cameron Dawson [:camd]]

Thanks for filing!  I'll get this fixed asap.  It's a regression due to the React code migration.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3268

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8954128 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3268

Looks good :-)

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/598396839268d99d935b6c676c25728b5de8b1a6
Bug 1440862 - Fix wording waiting for new push

Comment 5

[Botond Ballo [:botond]]

This seems to have regressed again.

Comment 6

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #5)
> This seems to have regressed again.

Though, it seems, only intermittently.

Comment 7

[Ed Morley [:emorley]]

Could you file a new bug please? (With as much STR as is viable given STR so tricky)

Comment 8

[Ed Morley [:emorley]]

s/so/is/