Closed Bug 1440868 Opened 6 years ago Closed 6 years ago

:matches() pseudo-selector is undocumented

Categories

(Developer Documentation Graveyard :: CSS, defect, P1)

All
Other
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sean.poulter, Assigned: cmills)

References

()

Details

:: Developer Documentation Request

      Request Type: New Documentation
     Gecko Version: unspecified
 Technical Contact: ARRAY(0x7fe9d55cc6a8)

:: Details

At this time there is no page documenting the `:matches()` CSS4 pseudo-selector. The spec is still a working draft, but it supported in Safari and iOS Safari.

The spec: https://developer.mozilla.org/en-US/docs/Web/CSS/:matches
Can I Use :matches pseduo-selector: https://caniuse.com/#feat=css-matches-pseudo
Expected URL: https://developer.mozilla.org/en-US/docs/Web/CSS/:matches
Priority: P5 → P1
Hi Sean,

Thanks for bringing this to our attention!

I've done this:

https://github.com/mdn/data/pull/186
https://github.com/mdn/browser-compat-data/pull/1223
https://developer.mozilla.org/en-US/docs/Web/CSS/:matches()

Let me know what you think.
Assignee: nobody → cmills
Thanks Chris. That's exactly what I was looking for. :)


Do the PRs or a script error affect the Syntax section on the wiki?

1. I'm setting a warning at the top saying "There was a scripting error on this page. While it is being addressed by site editors, you can view partial content below." Not sure if that's caused by my version of Chrome being unsupported or something else.

2. The content of the Syntax section appears as: {{csssyntax}}. I expect that's dependent on your PR to mdn/data#186, eh?
(In reply to sean.poulter from comment #2)
> Thanks Chris. That's exactly what I was looking for. :)
> 
> 
> Do the PRs or a script error affect the Syntax section on the wiki?
> 
> 1. I'm setting a warning at the top saying "There was a scripting error on
> this page. While it is being addressed by site editors, you can view partial
> content below." Not sure if that's caused by my version of Chrome being
> unsupported or something else.

This is because the page slug (:matches()) did not support the selector's entry in our data repo (:matches), which brought the {{csssyntax}} macro crashing to a halt. I've updated this now, and am just waiting for final acceptance of the PR.

> 
> 2. The content of the Syntax section appears as: {{csssyntax}}. I expect
> that's dependent on your PR to mdn/data#186, eh?

See above - this is the same problem. When a macro doesn't render, the call just gets spat out on the page as raw text.
Thanks Chris. Would it help if I added comments to the PR?
(In reply to sean.poulter from comment #4)
> Thanks Chris. Would it help if I added comments to the PR?

These problems should be fixed soon - I submitted PRs to do so, so it's just a matter of waiting.
I just merged https://github.com/mdn/kumascript/pull/687, which will (I hope!) make the syntax error in the page go away. The only remaining piece here is https://github.com/mdn/data/pull/186.
(In reply to Will Bamberg [:wbamberg] from comment #6)
> I just merged https://github.com/mdn/kumascript/pull/687, which will (I
> hope!) make the syntax error in the page go away. The only remaining piece
> here is https://github.com/mdn/data/pull/186.

Yes, it's fixed it — thanks Will!

In that case, I am going to close this bug for now, as this is specifically concerned with documenting the selector. And that part's now complete.
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.