Port bug 1440491 to TB: Remove [persist] attribute from elements without IDs

RESOLVED FIXED in Thunderbird 60.0

Status

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 60.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

Last year
In bug 1440491 they removed the persist attribute because they have no IDs and calculate the width of them in JS.
Assignee

Comment 1

Last year
Port of https://hg.mozilla.org/mozilla-central/rev/d49f13abd54a and https://hg.mozilla.org/mozilla-central/rev/738845c4c146fdb65dd3d18413b41425bf570f31#l1.10.

We have IDs, but they are sooo long and not used except for the persistence. With the width calculation in JS it's not needed to save the width in xulstore.json. I also added some #ifndef to be in synch with FX and also because Mac doesn't needs the placeholder in the menu toolbar because the system menubar is used.

To test the patch, you need drawInTitlebar enabled and check, that the tabs or Lightning buttons don't overlap the caption buttons.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8953747 - Flags: review?(jorgk)

Comment 2

Last year
Since bug 1440491 and bug 1424095 landed at the end of January, my W10 build which is a few days old should be good enough to test this, right? You want me to look at the caption buttons.
Assignee

Comment 3

Last year
Yes...and Win 7 too. This caption buttons should also not be covered.

Comment 4

Last year
Comment on attachment 8953747 [details] [diff] [review]
noPersist.patch

Works fine on Win7. If you draw tabs in titlebar and also disable the menu, all looks OK. I've noticed that there are about 50px of space to the left of the calendar items to the right-most tab or tab arrow. I think that could be reduced, no? This way, more tabs would fit before the arrows show.
Attachment #8953747 - Flags: review?(jorgk) → review+
Assignee

Comment 5

Last year
It's 40px ;) and it's to let some space to make it possible to drag the window also when it's full of tabs.
Keywords: checkin-needed

Comment 6

Last year
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/023618a6bc8d
Port bug 1440491 to TB: Remove [persist] attribute from elements without IDs. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

Last year
Target Milestone: --- → Thunderbird 60.0
You need to log in before you can comment on or make changes to this bug.