1440925 - Dark text and dark icons hard to see on the inactive tabs

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[WaltS48 [:walts48]]

Attachment: afterupdatetabs.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180224103027

Steps to reproduce:

Using Ubuntu 16.04LTS with the default Ubuntu Ambiance theme and the default Thunderbird Theme

Start Daily 60.0a1 BuildID: 20180223030201 built from https://hg.mozilla.org/comm-central/rev/c6418eab10bc0b2bf89e11427786a7b5cb0b4bb2

Update to Daily 60.0a1 BuildID: 20180224030201 built from https://hg.mozilla.org/comm-central/rev/3b00b92e534282c6760f3a7fed1e7d747090d08a



Actual results:

After applying the update and restarting the dark text and dark icons are hard to see on the inactive tabs.



Expected results:

Text and icons should appear in white on inactive tabs as in the previous builds.

Comment 1

[WaltS48 [:walts48]]

Attachment: beforeupdatetabs.png

Added a before image attachment

Comment 2

[Richard Marti (:Paenglab)]

Confirmed with Ambiance.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Linux-tabbar.patch

Strange that this changed yesterday without a obvious change. Maybe it's a change in a gfx library.

Aceman to test it you need a Linux theme with a dark menu bar like "Ambiance". Or you could make a VM with a plain Ubuntu. This is always handy to test things which don't work on your special configuration.

Comment 4

[:aceman]

I'd say my configuration is the most standard (as upstream developers created it), without any random distro modifications.
I do not see the dark titles even with the "Ubuntu Ambiance theme" from AMO. Is other theme meant here? You mean a theme for the whole desktop (Gnome or whatever Ubuntu drags)?

Comment 5

[WaltS48 [:walts48]]

(In reply to :aceman from comment #4)
> I'd say my configuration is the most standard (as upstream developers
> created it), without any random distro modifications.
> I do not see the dark titles even with the "Ubuntu Ambiance theme" from AMO.
> Is other theme meant here? You mean a theme for the whole desktop (Gnome or
> whatever Ubuntu drags)?

The theme for the whole desktop as set by going to the Ubuntu System Settings > Appearance window and selecting Ambiance for the theme. It should be the default on a fresh Ubuntu installation.

Thunderbird's theme is the default theme it ships with on a fresh installation.

Comment 6

[Richard Marti (:Paenglab)]

Ambiance is a Linux (GTK) theme and not a TB theme. TB should be the default theme.

Comment 7

[:aceman]

Comment on attachment 8953806 [details] [diff] [review]
Linux-tabbar.patch

Review of attachment 8953806 [details] [diff] [review]:
-----------------------------------------------------------------

Then I can't test it right now, but at least it does not break appearance on my system.

Comment 8

[Richard Marti (:Paenglab)]

Who else could test or review it? What if you give r+ and Walt checks it after it lands? Or I start a try which Walt can test.
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=d58d9c002526a513479af3e9b6354fa5830c410f

Comment 9

[:aceman]

Yeah, test on the try build could work.

Comment 10

[Richard Marti (:Paenglab)]

Walt, test builds can be found at https://archive.mozilla.org/pub/thunderbird/try-builds/[e-mail]-d58d9c002526a513479af3e9b6354fa5830c410f/try-comm-central-linux64/

Comment 11

[WaltS48 [:walts48]]

(In reply to Richard Marti (:Paenglab) from comment #10)
> Walt, test builds can be found at
> https://archive.mozilla.org/pub/thunderbird/try-builds/richard.marti@gmail.
> com-d58d9c002526a513479af3e9b6354fa5830c410f/try-comm-central-linux64/

Looks good! Back to the beforeupdates image again.

Comment 12

[:aceman]

Comment on attachment 8953806 [details] [diff] [review]
Linux-tabbar.patch

Review of attachment 8953806 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the testing.

Comment 13

[Richard Marti (:Paenglab)]

Thanks to both.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/02cf86823dd9
Use the menubar text color/appearance on the tabs-toolbar. r=aceman