1440940 - Add tests to prevent regression in collation lookups

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, enhancement)

Description

[ryan]

Currently we have code to allow proper locale-based collation lookups (cf Bug 1346180), but we only have a unit test hardcoded to the sql ending with a certain string.

The problem we have is in upgrading to Django 1.11 the sql changes, so we need some tests to ensure that collation lookup works correctly irrespective of the underlying sql.

It seems that the only locale that has been fixed is Turkish, so for now we are looking at just adding the tests (and required fixes in travis/docker) for Turkish. We can look at fixing/testing other locales once this in place.

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/8d03d6a0cc28a74c888c3d505f0429a7195c1690
Touch Bug 1440940: Docker postgres collations #866

- Add pontoon-postgres Dockerfile
- Use pontoon-postgres in docker-compose

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/c401ec837b1ccc87122204427ff1495748f8f13a
Touch Bug 1440940: Add tr locale in travis env

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/873

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/2a85ea6c33fd7a8279f01b35616bd313a45c68cc
Touch Bug 1440940: Collation test env #873

- Add collation setup in test db env
- Move language pack install to addons
- remove the collation setting as it didnt seem to work for the test db.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/875

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/548ac9d9ad385ce7ab94ba22ae7e7754ea5ef4e4
Fix bug 1440940:Add tests to prevent regression in collation lookups.