Closed
Bug 1440956
Opened 6 years ago
Closed 6 years ago
xpcshell test_AboutNewTabService.js is going to permafail when Gecko 60 merges to Beta on 2018-03-01
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
VERIFIED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | verified |
People
(Reporter: aryx, Assigned: aryx)
References
Details
Attachments
(1 file)
central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ec1a03ab522e89bcf1d3ee524dcfb2e25b6995b&selectedJob=164168398 Failure log: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ec1a03ab522e89bcf1d3ee524dcfb2e25b6995b&selectedJob=164168398 [task 2018-02-25T00:27:04.552Z] 00:27:04 WARNING - TEST-UNEXPECTED-TIMEOUT | browser/components/newtab/tests/xpcshell/test_AboutNewTabService.js | Test timed out ... [task 2018-02-25T00:27:04.597Z] 00:27:04 INFO - TEST-PASS | browser/components/newtab/tests/xpcshell/test_AboutNewTabService.js | test_default_url - [test_default_url : 100] Newtab defaultURL initially set to prerendered AS url - "resource://activity-stream/prerendered/en-US/activity-stream-prerendered.html" == "resource://activity-stream/prerendered/en-US/activity-stream-prerendered.html" [task 2018-02-25T00:27:04.597Z] 00:27:04 INFO - <<<<<<< The destructuring at https://hg.mozilla.org/mozilla-central/rev/e7d8e299023a#l2.12 fails because AppConstants has RELEASE_OR_BETA but the test expects IS_RELEASE_OR_BETA. The code landed in bug 1428108.
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8953790 [details] Bug 1440956 - Don't use AppConstants destructuring in test_AboutNewTabService.js because property name and variable name don't match. https://reviewboard.mozilla.org/r/222984/#review228860
Attachment #8953790 -
Flags: review+
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/f9feff68a41c Don't use AppConstants destructuring in test_AboutNewTabService.js because property name and variable name don't match. r=Mardak
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f9feff68a41c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8953790 [details] Bug 1440956 - Don't use AppConstants destructuring in test_AboutNewTabService.js because property name and variable name don't match. https://reviewboard.mozilla.org/r/222984/#review228974
Attachment #8953790 -
Flags: review?(andrei.br92) → review+
Assignee | ||
Comment 6•6 years ago
|
||
Verified fixed with https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c6b6d66cbfb42a470dda027a9104d9c24f7ee60&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=pending&filter-resultStatus=running&group_state=expanded
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•