1440977 - DevEdition cannot change theme from "Dark" to "Default" directly in Customize

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect, P3)

Description

[magicp]

Attachment: steps-to-reproduce_20180225_180116.mp4

Steps to reproduce:
1. Launch Firefox Developer Edition with a new profile
2. Navigate to Hamburger menu > Customize...
3. Click "Themes" button
4. Change theme from "Dark" to "Default"


Actual results:
Unable to change theme from "Dark" to "Default" directly in Customize. And also in about:addons, "Default" theme does not have "Enable" button. It works when once enabling "Light" theme.


Expected results:
Is this intentional? If not, it works fine.

Comment 1

[:Gijs (he/him)]

No, not intentional... any chance you can work out when this broke? :-\

Comment 2

[magicp]

(In reply to :Gijs from comment #1)
> No, not intentional... any chance you can work out when this broke? :-\

If this is intentional, it is a make sense because DevEdition’s DEFAULT is ‘Dark’.

Comment 3

[:Gijs (he/him)]

(In reply to magicp from comment #2)
> (In reply to :Gijs from comment #1)
> > No, not intentional... any chance you can work out when this broke? :-\
> 
> If this is intentional, it is a make sense because DevEdition’s DEFAULT is
> ‘Dark’.

I can see the logic there, but if we followed that logic we should have renamed things. Either way, these items should work - and they used to...

Comment 5

[:Gijs (he/him)]

Markus, can you try to find out when this broke?

Comment 6

[Markus Jaritz [:markus] (UX)]

Attachment: Firefox-Dev-Edition-Change-Theme-to-Default-does-not-work-firstVersion55.0b1.gif

First version I see this is 55.0b1 ... 
back the the UI looks quite different. Starting with that version, 2 themes look like they are selected by default... and clicking on the default, gives a preview, but does not apply it. (see attachment)

Comment 7

[atlanto]

Maybe bug 1365509 (https://hg.mozilla.org/mozilla-central/rev/396de980a0d5) caused this regression.

Steps To Inspect: (60.0b2)
1. Start Firefox with new profile.
2. Check "Enable browser chrome and add-on debugging toolboxes" in advanced settings.
3. Open Customize.
4. Make sure "Themes"->"Default" doesn't work.
5. Open Browser Console.
6. Enter following code.
  Cu.import("resource://gre/modules/AddonManager.jsm");
  AddonManagerPrivate.notifyAddonChanged("[e-mail]" + "@personas.mozilla.org", "theme");
7. Make sure "Themes"->"Default" works now.

Another Steps To Inspect:
1. Start Firefox with new profile.
2. Exit Firefox immediately.
3. Open extensions.json under the new profile folder with a text editor.
4. Find "The default theme".
5. Replace "userDisabled":false to "userDisabled":true and save the file.
6. Start Firefox.
7. Make sure "Themes"->"Default" works now.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Looking unlikely we'll get an upliftable fix for 60 in a useful timeframe, but would be nice if we could get this fixed on 61 as it moves to DevEdition next week.

Comment 10

[:Gijs (he/him)]

WFM in 79.