1440980 - Move modules as a sub-module to calUtils.jsm

Status: RESOLVED FIXED

(Calendar :: Internal Components, enhancement)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

We have a few modules that already provide a cal.foo namespace. To streamline this with the current flow, I'd say we move them to be loaded via lazy module getter.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: [part 1] calAlarmUtils - v1

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: [part 2] calAsyncUtils - v1

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: [part 3] calAuthUtils - v1

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: [part 4] calPrintUtils - v1

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: [part 5] calXMLUtils - v1

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: [part 1] calAlarmUtils - v2

Sorry about the extra bugmail, I made some fixes to the patches but I don't remember to which ones. I'm just going to go ahead and replace them all.

We really need to find a way to make phab usable without mfa, this would have been so much easier. I spent an hour diffing patches and trying to automate it :D

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: [part 2] calAsyncUtils - v2

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: [part 3] calAuthUtils - v2

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: [part 4] calPrintUtils - v2

Comment 10

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: [part 5] calXMLUtils - v2

Comment 11

[[:MakeMyDay]]

Comment on attachment 8953869 [details] [diff] [review]
[part 3] calAuthUtils - v2

Review of attachment 8953869 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the below nits fixed.

::: calendar/base/modules/calAuthUtils.jsm
@@ +31,5 @@
> +            this.mReturnedLogins = {};
> +            this.mProvider = null;
> +        }
> +
> +        getPasswordInfo(aPasswordRealm) {

Can you add a doc block here?

@@ +132,5 @@
> +         * @throw NS_ERROR_NOT_IMPLEMENTED
> +         *        Asynchronous authentication prompts are not supported;
> +         *        the caller should fall back to promptUsernameAndPassword().
> +         */
> +        asyncPromptAuth(aChannel, aCallback, aContext, aLevel, aAuthInfo) {

Can you please add the param description to the doc block?

@@ +165,5 @@
> +
> +            let hostKey = aChannel.URI.prePath + ":" + aAuthInfo.realm;
> +            gAuthCache.planForAuthInfo(hostKey);
> +
> +            function queuePrompt() {

Can you make this:

let queuePrompt = function() {

since the definition is not at the top of the parent function.

Comment 12

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: [part 3] calAuthUtils - v2

(In reply to [:MakeMyDay] from comment #11)
> @@ +132,5 @@
> > +         * @throw NS_ERROR_NOT_IMPLEMENTED
> > +         *        Asynchronous authentication prompts are not supported;
> > +         *        the caller should fall back to promptUsernameAndPassword().
> > +         */
> > +        asyncPromptAuth(aChannel, aCallback, aContext, aLevel, aAuthInfo) {
> 
> Can you please add the param description to the doc block?
This was copy/paste from the idl file. I opted for removing this doc block for that reason.

I also added calAuthUtils to the jsdoc eslint and made sure all types are set.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8465c91e98ae
Load sub-modules via calUtils.jsm - calAlarmUtils. r=MakeMyDay
https://hg.mozilla.org/comm-central/rev/bb34e24218cd
Load sub-modules via calUtils.jsm - calAsyncUtils. r=MakeMyDay
https://hg.mozilla.org/comm-central/rev/affb168e0997
Load sub-modules via calUtils.jsm - calAuthUtils. r=MakeMyDay
https://hg.mozilla.org/comm-central/rev/38580db43336
Load sub-modules via calUtils.jsm - calPrintUtils. r=MakeMyDay
https://hg.mozilla.org/comm-central/rev/46d63f72f75a
Load sub-modules via calUtils.jsm - calXMLUtils. r=MakeMyDay

Comment 14

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

https://hg.mozilla.org/releases/comm-beta/a6929adf17c7
Bug 1440980 - Load sub-modules via calUtils.jsm - calXMLUtils. r=MakeMyDay
https://hg.mozilla.org/releases/comm-beta/8115b369502e
Bug 1440980 - Load sub-modules via calUtils.jsm - calPrintUtils. r=MakeMyDay
https://hg.mozilla.org/releases/comm-beta/663b00b2e719
Bug 1440980 - Load sub-modules via calUtils.jsm - calAuthUtils. r=MakeMyDay
https://hg.mozilla.org/releases/comm-beta/331dec9e691a
Bug 1440980 - Load sub-modules via calUtils.jsm - calAsyncUtils. r=MakeMyDay
https://hg.mozilla.org/releases/comm-beta/495cc6dd8eae
Bug 1440980 - Load sub-modules via calUtils.jsm - calAlarmUtils. r=MakeMyDay

Comment 15

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/comm-beta/rev/a6929adf17c7
Bug 1440980 - Load sub-modules via calUtils.jsm - calXMLUtils. r=MakeMyDay
https://hg.mozilla.org/releases/comm-beta/rev/8115b369502e
Bug 1440980 - Load sub-modules via calUtils.jsm - calPrintUtils. r=MakeMyDay
https://hg.mozilla.org/releases/comm-beta/rev/663b00b2e719
Bug 1440980 - Load sub-modules via calUtils.jsm - calAuthUtils. r=MakeMyDay
https://hg.mozilla.org/releases/comm-beta/rev/331dec9e691a
Bug 1440980 - Load sub-modules via calUtils.jsm - calAsyncUtils. r=MakeMyDay
https://hg.mozilla.org/releases/comm-beta/rev/495cc6dd8eae
Bug 1440980 - Load sub-modules via calUtils.jsm - calAlarmUtils. r=MakeMyDay