Rules inside the shadow root shouldn't affect shadow host.

RESOLVED FIXED in Firefox 60

Status

()

defect
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

(Blocks 1 bug)

unspecified
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

(Except :host rules, of course).

This causes at least testing/web-platform/tests/css/selectors/focus-within-shadow-001.html to fail.
Comment hidden (mozreview-request)
I think the logic errors that this fixes wrt XBL invalidation may fix bug 1440640.
Blocks: 1440640

Comment 3

a year ago
mozreview-review
Comment on attachment 8956051 [details]
Bug 1441022: Separate the XBL and shadow dom styling bits.

https://reviewboard.mozilla.org/r/224994/#review231508

r=me with the nit addressed.

::: servo/components/style/dom.rs:334
(Diff revision 1)
> +    /// Get the shadow host that hosts this ShadowRoot.
> +    fn style_data<'a>(&self) -> &'a CascadeData

"Get the style data of the shadow root." I suppose? It is not clear to me what is the best wording here, but the doc doesn't seem to be correct anyway.
Attachment #8956051 - Flags: review?(xidorn+moz) → review+

Comment 4

a year ago
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/eb1b51dfde21
Update test expectations. r=xidorn

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/eb1b51dfde21
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.