1441034 - Warn if a revision is unreviewed or if neither the author/reviewer have scm_level_3

Status: RESOLVED WONTFIX

(Conduit :: Lando, enhancement, P2)

Description

[Steven MacLeod [:smacleod]]

Lando should warn when the revision being landed has not been reviewed at all (a distinct but related case of a previous diff of a revision having been reviewed. See related bug 1437234).

Additionally we should probably have a warning if neither the reviewer or author have scm_level_3 (or whatever scm level the repo requires). This will prevent sheriffs from clicking land on things that haven't received review from a proper reviewer / have an author that could just land themselves.

Something we might also want to consider is if the author not being level 3 themselves should mean a revision being accepted older (review on older diff) is a hard blocker rather than a warning. This would prevent sheriffs landing diffs from untrusted that have been updated since review. This could be contentious though.

scm_level_3 above should be replaced with a proper permissions system eventually, but it is our best proxy right now.

Comment 1

[Steven MacLeod [:smacleod]]

Mark, I didn't really know where we'd want to fit this into the stories, so I didn't make it block one. The work involved here definitely wasn't considered for Bug 1437237, so if you really want it done as part of that story re-estimation would make sense (or even making this its own story to come right after).

Please prioritize / link this up how you like.

Comment 2

[Mark Côté [:mcote]]

Shouldn't be a hard blocker until we have an official policy in place that such things are disallowed.  That said, please implement this in a way that would make that easy. :)

I'll make this its own story.

Comment 3

[Steven MacLeod [:smacleod]]

We're going to jump directly to using module ownership/peership information rather than scm level.