1441039 - URL not being replaced after removing and clicking link

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[me]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20180206200532

Steps to reproduce:

Go to a youtube video, find one you REALLY like. Cut the URL (Ctrl +A, Ctrl + X) to copy all of it and send it to a friend if you feel like it. After that click on a video from recommended and the URL for the video you clicked does not load in the URL bar.


Actual results:

It was blank after clicking


Expected results:

It should populate with the new URL.

Comment 1

[Emil Pasca [:emilpasca]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

I have tested this issue on Windows 10 x64 with the latest Firefox release (58.0.2) and the latest Nightly (60.0a1-20180228100110) and managed to reproduce it.
After going to a YouTube video, after cutting the URL (Ctrl +A, Ctrl + X) and clicking on a video from the recommended section, the video is loaded, however, the URL for the corresponding video is not displayed in the address bar.

I think that the suitable component for this issue would be "Firefox: Address Bar".

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

This should be investigated, it's not ok to not show the url for privacy and security reasons.

Comment 3

[:Gijs (he/him)]

I expect this is to do with youtube not actually loading a URL if you click that link, it'll just use history.pushState() to change the URL, and we will not overwrite the URL in that case if it's been edited (which in this case it has, it's just empty).

We should probably add an exception to that logic for the case where the URL bar is empty.

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1441039 - same-document changes should cause empty URL bar to fill back up for current tab, r?mak

Make URLBarSetURI more explicit about what it's looking for in `value`,
and ensure the tabbrowser's progress listeners reset the userTypeValue if it's
empty already and there's a same-site document change.

Comment 5

[:Gijs (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2720d919170717863fffd8a83b5ff1c4a297b59

Comment 6

[Phabricator Automation]

Comment on attachment 8992493 [details]
Bug 1441039 - same-document changes should cause empty URL bar to fill back up for current tab, r?mak

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D2181

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20d91313f771
same-document changes should cause empty URL bar to fill back up for current tab, r=mak

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/20d91313f771

Comment 9

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 60.0a1 (2018-02-25) on Windows 10, 64 Bit!
This bug's fix is verified with latest Nightly!

Build ID 	20180730221422
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Gijs, do you think we should nominate this for uplifts? Please go ahead and do so if yes :)

Comment 11

[:Gijs (he/him)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #10)
> Gijs, do you think we should nominate this for uplifts? Please go ahead and
> do so if yes :)

I think the URL bar is finnicky, and it's now very close to the end of the 62 cycle, and we've lived with this for aaaaages, so I don't think it's worth the risk. I'd rather have it bake longer. Could still nominate for esr "later". What do you want me to do with that flag?

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Let's just let it ride the trains.