1441127 - Find All feature at Debugger tab is not stable

Status: RESOLVED FIXED

(Firefox :: Untriaged, defect)

Description

[urielha2]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180222170353

Steps to reproduce:

ctrl+shift+I to go into developers tools.
Now open the Debugger tab and click ctrl+shift+F
Choose any word to find.


Actual results:

The feature is not stable, sometimes it finds the word that I'm looking for but most of the time it just stuck.
I really liked the way "find all" worked in the old Debugger design.
Moreover, I can't append letters to the middle of the search word (the cursor is jumping to the end of the word in each keyboard click).



Expected results:

Fins should work and give correct feedback of the search.
No cursor jumping.

Comment 1

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID 	20180301024724

Hi,

I was unable to reproduce the issue you have experienced on the latest Nightly and latest Dev edition. I've navigated to https://www.mozilla.org/en-US/firefox/nightly/firstrun/ , searched for different terms and each time the lines that contained the keyword were displayed. I was able to append letters to the middle of a searched term and search again.

Could you please try to reproduce the issue using a new clean Firefox profile (https://goo.gl/AWo6h8), maybe even safe mode (https://goo.gl/AR5o9d), to eliminate custom settings as a possible cause? If the issue is still reproducible, could you please post the contents of the about:support page in this bug?

Comment 2

[urielha2]

Hi, 
Thanks for the response!

I downloaded the nightly build and it seems like the search is indeed working here (I could change letters in the middle of the search and the search term is being found).

Still, in my opinion, it is a bit less comfortable from the old debugger (setting devtools.debugger.new-debugger-frontend to false) because the font (size and style) of the results is really small and without colors, is there a way to configure that?

Best regards.

Comment 3

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

@urielha2, could you please check and see if your issue is reproducible on the latest Beta, using Dev edition? Also, could you please post a link of the page you initially saw this issue?

@jlast, do you think you can answer the question in comment 2?

Comment 4

[Jason Laster [:jlast]]

Hi @urielha2, 

Just to understand do you prefer the fact that the old debugger had a smaller font without colors? Was this because it showed more results in a smaller space?

Comment 5

[urielha2]

Hi,
First of all I would like to mention that the original bugs I wrote:
- Feature is not stable
- Can't append letters to the middle of the search word

Are NOT reproducible on the latest Beta. Still, IMO, the experience is better in the old debugger.

@jlaster, 
Actually I meant the opposite - The old debugger HAD slight bigger font WITH colors - and that's what I preferred.
But now that I check it, it seems like the old debugger doesn't have colors so maybe I just got confused about this one :S

Here some pictures to clarify the differences:

[Old vs New - bottom picture has case mismatch]
   Old: https://i.imgur.com/d3JOd7z.png
   New: https://i.imgur.com/fR4ivKV.png

   (Case sensitive option in about:config https://i.imgur.com/k65xcCX.png)

[Old vs New - overall experience]
   Old : https://i.imgur.com/yTMfi8t.gif
   New (not emphasizes the found word): https://i.imgur.com/4NBhQG2.gif


All above examples are from the current page (https://bugzilla.mozilla.org/show_bug.cgi?id=1441127) but also occurred to me on other pages.

Comment 6

[Jason Laster [:jlast]]

Thanks, i'll keep this in mind as we work on "Find all".

I'm going to close this as we work here http://github.com/devtools-html/debugger.html/issues/

And we're currently planning a design pass for search in a couple of months

Comment 7

[urielha2]

Thanks!