1441129 - Change the Memory Tool's Snapshot List Item delete button from a div to a button

Status: RESOLVED FIXED

(DevTools :: Memory, enhancement, P2)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

For accessibility reasons we should change the Memory Tool's Snapshot List Item delete button from a div to a button.

The code to change is inside the following files:
- devtools/client/memory/components/SnapshotListItem.js
- devtools/client/themes/memory.css

Comment 1

[Mayank Madan [:mayankmadan]]

Can I work on this?

Comment 2

[Souvik Mandal]

Hello sir, I am interested to work on it.I am new here.Can I do it?

Comment 3

[Julien Wajsberg [:julienw]]

Hi Mayank and Souvik !
Thanks a lot for your interest in this bug.

Because Mayank asked first I believe he should get the precedence to fix this bug :-)
Souvik I'm sure you'll find other bugs to work on!

Comment 4

[Mayank Madan [:mayankmadan]]

Attachment: button.diff

I think this patch will do

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8954866 [details] [diff] [review]
button.diff

Review of attachment 8954866 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for working on this so quickly!

I should have explained in the bug description that we want to preserve the appearance of the close button.

I would suggest that to accomplish this you drop your current CSS changes and add the following to `.snapshot-list-item .delete`:
  background-color: transparent;
  border: 0;
  color: currentColor;
  padding: 0;

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Before.png

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: After.png

Comment 8

[Mayank Madan [:mayankmadan]]

Attachment: button.diff

Comment 9

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8955075 [details] [diff] [review]
button.diff

Review of attachment 8955075 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, r+

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7516a83ba950
"Change the Memory Tool's Snapshot List Item delete button from a div to a button" [r=mratcliffe]

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7516a83ba950