1441147 - Upgrade redux and react-redux to remove react-dev warnings

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P2)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Since our upgrade to React 16 we have the following warning in the memory tool:

`"Warning: Failed prop type: Calling PropTypes validators directly is not supported by the `prop-types` package. Use `PropTypes.checkPropTypes()` to call them."`

The most common cause of this error is incompatibilities between redux and the current version of react.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1441147 - Upgrade redux and react-redux to remove react-dev warnings

This is as simple as an upgrade can be. Everything still appears to work but we should ensure try is green before landing.

Review commit: https://reviewboard.mozilla.org/r/223140/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223140/

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8953985 [details]
Bug 1441147 - Upgrade redux and react-redux to remove react-dev warnings

https://reviewboard.mozilla.org/r/223140/#review229068

Seems legit

::: devtools/client/shared/vendor/REDUX_UPGRADING.md:1
(Diff revision 1)
> -/* This Source Code Form is subject to the terms of the Mozilla Public
> +[//]: # (

what's this syntax ? Never saw it

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #2)
> Comment on attachment 8953985 [details]
> Bug 1441147 - Upgrade redux and react-redux to remove react-dev warnings
> 
> https://reviewboard.mozilla.org/r/223140/#review229068
> 
> Seems legit
> 
> ::: devtools/client/shared/vendor/REDUX_UPGRADING.md:1
> (Diff revision 1)
> > -/* This Source Code Form is subject to the terms of the Mozilla Public
> > +[//]: # (
> 
> what's this syntax ? Never saw it

It is an invisible link used to provide comments in markdown.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c0478c4185c
Upgrade redux and react-redux to remove react-dev warnings r=nchevobbe

Comment 5

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/1c0478c4185c