1441165 - Use NotNull for nsINode::OwnerDoc()

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Use NotNull for nsINode::OwnerDoc()

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8954001 [details] [diff] [review]
Use NotNull for nsINode::OwnerDoc()

>+++ b/dom/base/NodeInfo.h
>@@ -276,17 +277,17 @@ protected:
>     bool              mHashInitialized;
>   };
> 
>   // nsNodeInfoManager needs to pass mInner to the hash table.
>   friend class ::nsNodeInfoManager;
> 
>   // This is a non-owning reference, but it's safe since it's set to nullptr
>   // by nsNodeInfoManager::DropDocumentReference when the document is destroyed.
>-  nsIDocument* MOZ_NON_OWNING_REF mDocument; // Cache of mOwnerManager->mDocument
>+  NotNull<nsIDocument*> MOZ_NON_OWNING_REF mDocument; // Cache of mOwnerManager->mDocument
this isn't right. The NodeInfo for Document may overlive Document itself, and NodeInfo::mDocument should be set to null in that case.

>-// static
>-int
>-nsNodeInfoManager::DropNodeInfoDocument(PLHashEntry *he, int hashIndex, void *arg)
>-{
>-  static_cast<mozilla::dom::NodeInfo*>(he->value)->mDocument = nullptr;
>-  return HT_ENUMERATE_NEXT;
>-}
>-
> void
> nsNodeInfoManager::DropDocumentReference()
> {
>   if (mBindingManager) {
>     mBindingManager->DropDocumentReference();
>   }
> 
>-  // This is probably not needed anymore.
>-  PL_HashTableEnumerateEntries(mNodeInfoHash, DropNodeInfoDocument, nullptr);
>-
So I don't see how this can be removed

Comment 3

[Masatoshi Kimura [:emk]]

So this is not possible, unfortunately :(