Closed Bug 1441198 Opened 3 years ago Closed 3 years ago

The Cookies and Site Data UI from about:preferences#privacy doesn't match the specifications

Categories

(Firefox :: Preferences, defect, P1)

60 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 60
Tracking Status
firefox60 --- verified

People

(Reporter: roxana.leitan, Assigned: johannh, NeedInfo)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

Attached image site storage UI.png
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180226100105

[Affected versions]:
Nightly 60.0a1

[Affected platforms]:
Ubuntu 16.04 X64, Windows 10 x64

[Steps to reproduce]:
1.Launch Nightly 60.0a1 with a new profile
2.Go to about:preferences#privacy - Cookies and Site Data section

[Expected result]:
The Cookies and Site Data section should match the specifications: https://mozilla.invisionapp.com/share/3YEUL9R7N#/screens

[Actual result]:
The Cookies and Site Data UI from about:preferences#privacy doesn't match the specifications
Ah, good point on that extra space and (recommended), thanks!

I'm not sure we should say "your cookies, site data and cache" are using this much space... because we're not really counting cookie size there. Jacqueline, is that fine with you?
Flags: needinfo?(jsavory)
I'm hesitant to remove the cookies part as we are kind of indicating in that sentence what the "Clear Data..." button will do, which is also clear your cookies. However I don't want to make users start thinking that cookies are taking up large portions of their memory. 

NI? Michelle, what is your opinion here?
Flags: needinfo?(jsavory) → needinfo?(mheubusch)
I have patches for this and a couple of other small glitches I noticed during fixing this.
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Priority: -- → P1
Blocks: 1441138
Blocks: 1441766
Nihanth, sorry for the messy request upload, not sure what went wrong the first time... Please ignore the interdiff. Further description of the changes are in the commit messages. Feel free to ask questions, but I think the patches should be fairly straightforward.
Comment on attachment 8954699 [details]
Bug 1441198 - Part 1 - Use correct copy for cookies and site data in about:preferences.

https://reviewboard.mozilla.org/r/223818/#review229884
Attachment #8954699 - Flags: review?(nhnt11) → review+
Comment on attachment 8954693 [details]
Bug 1441198 - Part 2 - Fix side spacing and line breaking of items adjacent to the site data description in about:preferences.

https://reviewboard.mozilla.org/r/223816/#review229886

::: browser/themes/shared/incontentprefs/preferences.inc.css:91
(Diff revision 3)
>  }
>  
> +/* Add a bit of space to the end of descriptions to
> + * leave margin with e.g. additional buttons on the side. */
> +.description-with-side-element {
> +  margin-inline-end: 10px !important;

I won't block r+, but I'd like to express the usual caution around adding an !important. Probably good to spend an extra ~30 seconds (probably not more than that though) to think of a way to avoid needing this.
Attachment #8954693 - Flags: review?(nhnt11) → review+
Comment on attachment 8954690 [details]
Bug 1441198 - Part 3 - Add some space above the cookies preferences.

https://reviewboard.mozilla.org/r/223810/#review229888
Attachment #8954690 - Flags: review?(nhnt11) → review+
Attached image exceptions panel.png
The Exceptions panel title doesn't match the specs
(In reply to Jacqueline Savory [:jsavory] UX from comment #2)
> I'm hesitant to remove the cookies part as we are kind of indicating in that
> sentence what the "Clear Data..." button will do, which is also clear your
> cookies. However I don't want to make users start thinking that cookies are
> taking up large portions of their memory. 

Given that try looks good, we should probably get this in sooner rather than later. I'm tempted to just land the patches without blocking on the discussion (matching the spec and including "cookies" in the description for now). We can file a follow-up bug when jsavory and mheubusch had time to discuss this.
https://hg.mozilla.org/integration/mozilla-inbound/rev/17ec5ecc5057aa69378e260aff120b0317efd0af
Bug 1441198 - Part 1 - Use correct copy for cookies and site data in about:preferences. r=nhnt11

https://hg.mozilla.org/integration/mozilla-inbound/rev/86dbf9b038d475000cf7fa62edba8714a60c43b9
Bug 1441198 - Part 2 - Fix side spacing and line breaking of items adjacent to the site data description in about:preferences. r=nhnt11

https://hg.mozilla.org/integration/mozilla-inbound/rev/a8f35224e73f485c6c9367a741cbc56faca065c4
Bug 1441198 - Part 3 - Add some space above the cookies preferences. r=nhnt11
Verified fixed using latest Nightly (2018-03-04) on Windows 10 x64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.