1441211 - Ensure that Safe Browsing gtests run

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P1)

Description

[François Marier [:francois]]

$ ./mach test-info toolkit/components/url-classifier/tests/gtest/TestFailUpdate.cpp 
===== toolkit/components/url-classifier/tests/gtest/TestFailUpdate.cpp =====
Found toolkit/components/url-classifier/tests/gtest/TestFailUpdate.cpp in source control.
Build configuration changed. Regenerating backend.
toolkit/components/url-classifier/tests/gtest/TestFailUpdate.cpp not found in any test manifest!
Querying ActiveData...
Unable to find matching records in ActiveData; using toolkit/components/url-classifier/tests/gtest/TestFailUpdate.cpp!

Test results for toolkit/components/url-classifier/tests/gtest/TestFailUpdate.cpp on mozilla-central,mozilla-inbound,autoland between 2018-02-19 and 2018-02-26
No test result data found.

Test durations for toolkit/components/url-classifier/tests/gtest/TestFailUpdate.cpp on mozilla-central,mozilla-inbound,autoland between 2018-02-19 and 2018-02-26
No test durations found.

Bugzilla quick search for 'toolkit/components/url-classifier/tests/gtest/TestFailUpdate.cpp,toolkit/components/url-classifier/tests/gtest/TestFailUpdate.cpp,TestFailUpdate.cpp':

Comment 1

[François Marier [:francois]]

I added an `ASSERT_TRUE(false)` in one of the ProtocolParser tests and then verified that it does fail the gtests when run manually:

  ./mach gtest ProtocolParser*

as well as on Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4075db560e7a100bd2f2e8b7d89eea5f3e963cea&selectedJob=172179255

Comment 2

[François Marier [:francois]]

Attachment: Bug 1441211 - Use common prefix for all URL Classifier gtests.

With a common prefix, all of the URL Classifier gtests can be run
like this:

  ./mach gtest UrlClassifier*

Review commit: https://reviewboard.mozilla.org/r/234262/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234262/

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8965494 [details]
Bug 1441211 - Use common prefix for all URL Classifier gtests.

https://reviewboard.mozilla.org/r/234262/#review240184

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca925c1b80e1
Use common prefix for all URL Classifier gtests. r=gcp

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ca925c1b80e1