Closed Bug 1441226 Opened 4 years ago Closed 4 years ago

Rename NoAlertOpenError to NoSuchAlertError to match WebDriver

Categories

(Testing :: Marionette, defect, P3)

Version 3
defect

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

Attachments

(1 file)

The NoAlertOpenError type in testing/marionette/error.js should be
renamed to NoSuchAlertError to match the WebDriver specification.
It already carries the correct error code, so there is no chance
of a backwards incompatible change.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8954081 [details]
Bug 1441226 - Rename NoAlertOpenError to NoSuchAlertError.

https://reviewboard.mozilla.org/r/223236/#review229298

Picking review given that Maja is on PTO. r=me with the remaining issue fixed.

::: testing/marionette/error.js:492
(Diff revision 1)
>    ["invalid element state", InvalidElementStateError],
>    ["invalid selector", InvalidSelectorError],
>    ["invalid session id", InvalidSessionIDError],
>    ["javascript error", JavaScriptError],
>    ["move target out of bounds", MoveTargetOutOfBoundsError],
> -  ["no alert open", NoAlertOpenError],
> +  ["no alert open", NoSuchAlertError],

"no such alert"

::: testing/marionette/test_error.js:340
(Diff revision 1)
>  
> -add_test(function test_NoAlertOpenError() {
> -  let err = new NoAlertOpenError("foo");
> -  equal("NoAlertOpenError", err.name);
> +add_test(function test_NoSuchAlertError() {
> +  let err = new NoSuchAlertError("foo");
> +  equal("NoSuchAlertError", err.name);
>    equal("foo", err.message);
>    equal("no such alert", err.status);

This test should fail on try. :)
Attachment #8954081 - Flags: review+
Comment on attachment 8954081 [details]
Bug 1441226 - Rename NoAlertOpenError to NoSuchAlertError.

https://reviewboard.mozilla.org/r/223236/#review229298

Thanks for the quick review!
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s bfe8da55ab9549e627d8834321aeaa5737869b63 -d 8e612e57fc49: rebasing 449064:bfe8da55ab95 "Bug 1441226 - Rename NoAlertOpenError to NoSuchAlertError. r=whimboo" (tip)
merging testing/marionette/error.js
warning: conflicts while merging testing/marionette/error.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 65dceeb6b581230147828c3d7654127a957ebd3a -d 77d5fc984c50: rebasing 449107:65dceeb6b581 "Bug 1441226 - Rename NoAlertOpenError to NoSuchAlertError. r=whimboo" (tip)
merging testing/marionette/error.js
warning: conflicts while merging testing/marionette/error.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
I guess I need to wait for something on Autoland to land on central first?
Yes, it's your patch from bug 1441019. :)
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fbe5a80f2f5b
Rename NoAlertOpenError to NoSuchAlertError. r=whimboo
Backed out for linting Doc failures. 
backout: https://hg.mozilla.org/integration/autoland/rev/0ca3c363d6cc94e000216219deb684fe6878e444

push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=fbe5a80f2f5b2a7235fd17ba296c66b38846efeb

failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=165209582&repo=autoland&lineNumber=403

[task 2018-03-01T14:48:35.197Z] Traceback (most recent call last):
[task 2018-03-01T14:48:35.197Z]   File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenv/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 658, in import_object
[task 2018-03-01T14:48:35.197Z]     __import__(self.modname)
[task 2018-03-01T14:48:35.197Z]   File "/builds/worker/checkouts/gecko/build/mach_bootstrap.py", line 363, in __call__
[task 2018-03-01T14:48:35.197Z]     module = self._original_import(name, globals, locals, fromlist, level)
[task 2018-03-01T14:48:35.197Z]   File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/faster_daemon.py", line 30, in <module>
[task 2018-03-01T14:48:35.197Z]     import pywatchman
[task 2018-03-01T14:48:35.198Z]   File "/builds/worker/checkouts/gecko/build/mach_bootstrap.py", line 363, in __call__
[task 2018-03-01T14:48:35.198Z]     module = self._original_import(name, globals, locals, fromlist, level)
[task 2018-03-01T14:48:35.199Z] ImportError: No module named pywatchman
[task 2018-03-01T14:48:35.199Z] /builds/worker/checkouts/gecko/python/mozbuild/mozbuild/makeutil.py:docstring of mozbuild.makeutil.Rule:3: WARNING: Unexpected indentation.
[task 2018-03-01T14:48:35.199Z] /builds/worker/checkouts/gecko/python/mozbuild/mozbuild/util.py:docstring of mozbuild.util.StrictOrderingOnAppendListWithFlagsFactory:11: WARNING: Definition list ends without a blank line; unexpected unindent.
[task 2018-03-01T14:48:35.199Z] /builds/worker/checkouts/gecko/python/mozbuild/mozbuild/artifacts.py:docstring of mozbuild.artifacts:32: WARNING: Undefined substitution referenced: "mach artifact".
[task 2018-03-01T14:48:35.200Z] /builds/worker/checkouts/gecko/python/mozbuild/mozbuild/dotproperties.py:docstring of mozbuild.dotproperties.DotProperties.get_dict:3: WARNING: Undefined substitution referenced: "required_keys".
[task 2018-03-01T14:48:35.200Z] docstring of mozbuild.mach_commands.PackageFrontend.artifact:3: WARNING: Undefined substitution referenced: "mach build".
[task 2018-03-01T14:48:35.200Z] docstring of mozbuild.mach_commands.PackageFrontend.artifact:3: WARNING: Undefined substitution referenced: "mach artifact last".
[task 2018-03-01T14:48:35.200Z] /builds/worker/checkouts/gecko/python/mozbuild/mozbuild/mozinfo.py:docstring of mozbuild.mozinfo.write_mozinfo:1: WARNING: Undefined substitution referenced: "file".
[task 2018-03-01T14:48:35.201Z] /builds/worker/checkouts/gecko/docs-out/html/main/_staging/toolkit/components/telemetry/telemetry/collection/histograms.rst:26: WARNING: image file not readable: toolkit/components/telemetry/telemetry/collection/sampleHistogram.png
[task 2018-03-01T14:48:35.201Z] /builds/worker/checkouts/gecko/docs-out/html/main/_staging/mozbase/mozprocess.rst:321: WARNING: missing attribute processOutputLine in object mozprocess.ProcessHandlerMixin
[task 2018-03-01T14:48:35.201Z] /builds/worker/checkouts/gecko/docs-out/html/main/_staging/mozbase/mozprocess.rst:321: WARNING: missing attribute onTimeout in object mozprocess.ProcessHandlerMixin
[task 2018-03-01T14:48:35.201Z] /builds/worker/checkouts/gecko/docs-out/html/main/_staging/mozbase/mozprocess.rst:321: WARNING: missing attribute onFinish in object mozprocess.ProcessHandlerMixin
[task 2018-03-01T14:48:35.201Z] /builds/worker/checkouts/gecko/docs-out/html/main/_staging/testing/marionette/marionette/internals/message.rst:2: WARNING: Title underline too short.
[task 2018-03-01T14:48:35.201Z] 
[task 2018-03-01T14:48:35.202Z] message module
[task 2018-03-01T14:48:35.202Z] =============
[task 2018-03-01T14:48:35.202Z] /builds/worker/checkouts/gecko/docs-out/html/main/_staging/taskcluster/taskcluster/transforms.rst:26: WARNING: Error in "code-block" directive:
[task 2018-03-01T14:48:35.203Z] 1 argument(s) required, 0 supplied.
[task 2018-03-01T14:48:35.203Z] 
[task 2018-03-01T14:48:35.203Z] .. code-block::
[task 2018-03-01T14:48:35.203Z] 
[task 2018-03-01T14:48:35.203Z]     @transforms.add
[task 2018-03-01T14:48:35.203Z]     def transform_an_item(config, items):
[task 2018-03-01T14:48:35.204Z]         """This transform ..."""  # always a docstring!
[task 2018-03-01T14:48:35.204Z]         for item in items:
[task 2018-03-01T14:48:35.204Z]             # ..
[task 2018-03-01T14:48:35.204Z]             yield item
[task 2018-03-01T14:48:35.204Z] event.js:event(6):88: WARNING: Undefined substitution referenced: "type".
[task 2018-03-01T14:48:35.204Z] event.js:event(6):89: WARNING: Undefined substitution referenced: "window".
[task 2018-03-01T14:48:35.204Z] event.js:event(6):217: WARNING: Undefined substitution referenced: "aOffset + aLength".
[task 2018-03-01T14:48:35.204Z] event.js:event(6):217: WARNING: Undefined substitution referenced: "aOffset".
[task 2018-03-01T14:48:35.204Z] event.js:event(6):217: WARNING: Undefined substitution referenced: "aOffset".
[task 2018-03-01T14:48:35.204Z] event.js:event(6):217: WARNING: Undefined substitution referenced: "aOffset + aLength".
[task 2018-03-01T14:48:35.205Z] event.js:event(6):16: WARNING: Unknown target name: "vk".
[task 2018-03-01T14:48:35.205Z] event.js:event(6):46: WARNING: Unknown target name: "dom_vk".
[task 2018-03-01T14:48:35.205Z] event.js:event(6):116: WARNING: Unknown target name: "vk".
[task 2018-03-01T14:48:35.205Z] 
[task 2018-03-01T14:48:35.205Z] Sphinx error:
[task 2018-03-01T14:48:35.205Z] No JSDoc documentation was found for object "NoAlertOpenError" or any path ending with that.
[task 2018-03-01T14:48:35.205Z] ./mach: failed to generate documentation:
[task 2018-03-01T14:48:35.205Z] /builds/worker/checkouts/gecko/tools: sphinx return code 1
[task 2018-03-01T14:48:35.205Z] Archived to docs-out/main.tar.gz
[taskcluster 2018-03-01 14:48:35.553Z] === Task Finished ===
Flags: needinfo?(ato)
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61165dc3f54a
Rename NoAlertOpenError to NoSuchAlertError. r=whimboo
Fixed docs.
Flags: needinfo?(ato)
https://hg.mozilla.org/mozilla-central/rev/61165dc3f54a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.