1441228 - WebDriver:TakeScreenshot should return invalid argument error on malformed input

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement, P3)

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1441228 - Correct error returned for invalid input to capture.highlight_.

The WebDriver:TakeScreenshot command should return an invalid
argument error when the input is malformed.

Review commit: https://reviewboard.mozilla.org/r/223244/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223244/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8954084 [details]
Bug 1441228 - Correct error returned for invalid input to capture.highlight_.

https://reviewboard.mozilla.org/r/223244/#review229302

::: testing/marionette/capture.js:7
(Diff revision 1)
>   * License, v. 2.0. If a copy of the MPL was not distributed with this file,
>   * You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  "use strict";
>  
> +const {InvalidArgumentError} = ChromeUtils.import("chrome://marionette/content/error.js", {});

This should cause a linter failure because it extends 78 chars.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8954084 [details]
Bug 1441228 - Correct error returned for invalid input to capture.highlight_.

https://reviewboard.mozilla.org/r/223244/#review229302

> This should cause a linter failure because it extends 78 chars.

It doesn’t and I think perhaps the reason is that long strings are exempted.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b634845f959c
Correct error returned for invalid input to capture.highlight_. r=whimboo

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/b634845f959c