Closed Bug 1441242 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 9227 - [css-grid] Unprefix gutter properties

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: mozilla.org, Unassigned)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 9227 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/9227
Details from upstream follow.

Manuel Rego Casasnovas wrote:
>  [css-grid] Unprefix gutter properties
>  
>  This patch applies the resoultion of the CSS WG to unprefix
>  the CSS Grid Layout gutter properties:
>  https://github.com/w3c/csswg-drafts/issues/1696
>  
>  That is:
>  * grid-column-gap => column-gap
>  * grid-row-gap => row-gap
>  * grid-gap => gap
>  
>  column-gap already existed before, as it's part of Multicol,
>  and it already has an alias -webkit-column-gap.
>  For that reason it's not possible to implement another alias
>  for grid-column-gap, so it was done with a shorthand.
>  To follow the same pattern the shorthand approach was used for
>  grid-row-gap and grid-gap too.
>  
>  As column-gap was already animatable, this change takes advantage
>  to make animatable row-gap too.
>  
>  Intent to Implement and Ship thread:
>  https://groups.google.com/a/chromium.org/d/msg/blink-dev/UViBfJuuIq8/w7_2W7lLAgAJ
>  
>  Converted grid-gutters-get-set.html in some WPT tests covering
>  a few extra cases.
>  Added WPT test to verify the animation of these properties too.
>  
>  BUG=761904
>  TEST=external/wpt/css/css-align/gaps/
>  
>  Change-Id: If49ec34116eff0b3b745fc89b01b15b14c71d4a9
>  Reviewed-on: https://chromium-review.googlesource.com/890446
>  Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
>  Reviewed-by: Rune Lillesveen <futhark@chromium.org>
>  Reviewed-by: Kent Tamura <tkent@chromium.org>
>  Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
>  Cr-Commit-Position: refs/heads/master@{#534351}
>  
>  
>
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 16 tests and 128 subtests
OK     : 16
PASS   : 37
FAIL   : 91

New tests that have failures or other problems:
/css/css-align/gaps/column-gap-parsing-001.html
    column-gap accepts percentage: FAIL
/css/css-align/gaps/gap-animation-001.html
    gap is interpolable: FAIL
/css/css-align/gaps/gap-animation-002.html
    gap: normal is not interpolable: FAIL
/css/css-align/gaps/gap-animation-003.html
    Default gap is not interpolable: FAIL
/css/css-align/gaps/gap-animation-004.html
    gap is interpolable: FAIL
/css/css-align/gaps/gap-parsing-001.html
    'max-content' gap is invalid: FAIL
    'none' gap is invalid: FAIL
    Angle gap is invalid: FAIL
    Default gap is 'normal': FAIL
    Initial gap is 'normal': FAIL
    Initial gap is 'normal' 2: FAIL
    Initial inherited gap is 'normal': FAIL
    Negative gap is invalid: FAIL
    Resolution gap is invalid: FAIL
    Time gap is invalid: FAIL
    gap accepts calc(): FAIL
    gap accepts calc() 2: FAIL
    gap accepts em: FAIL
    gap accepts em 2: FAIL
    gap accepts percentage: FAIL
    gap accepts percentage 2: FAIL
    gap accepts pixels: FAIL
    gap accepts pixels 2: FAIL
    gap accepts pixels combined with percentage: FAIL
    gap accepts vw: FAIL
    gap accepts vw and vh: FAIL
    gap is inheritable: FAIL
    gap with one wrong value is invalid: FAIL
    gap with slash is invalid: FAIL
    gap with three values is invalid: FAIL
/css/css-align/gaps/grid-column-gap-parsing-001.html
    column-gap accepts percentage: FAIL
/css/css-align/gaps/grid-gap-parsing-001.html
    'max-content' gap is invalid: FAIL
    'none' gap is invalid: FAIL
    Angle gap is invalid: FAIL
    Default gap is 'normal': FAIL
    Initial gap is 'normal': FAIL
    Initial gap is 'normal' 2: FAIL
    Initial inherited gap is 'normal': FAIL
    Negative gap is invalid: FAIL
    Resolution gap is invalid: FAIL
    Time gap is invalid: FAIL
    gap accepts calc(): FAIL
    gap accepts calc() 2: FAIL
    gap accepts em: FAIL
    gap accepts em 2: FAIL
    gap accepts percentage: FAIL
    gap accepts percentage 2: FAIL
    gap accepts pixels: FAIL
    gap accepts pixels 2: FAIL
    gap accepts pixels combined with percentage: FAIL
    gap accepts vw: FAIL
    gap accepts vw and vh: FAIL
    gap is inheritable: FAIL
    gap with one wrong value is invalid: FAIL
    gap with slash is invalid: FAIL
    gap with three values is invalid: FAIL
/css/css-align/gaps/grid-row-gap-parsing-001.html
    'max-content' row-gap is invalid: FAIL
    'none' row-gap is invalid: FAIL
    Angle row-gap is invalid: FAIL
    Default row-gap is 'normal': FAIL
    Initial inherited row-gap is 'normal': FAIL
    Initial row-gap is 'normal': FAIL
    Initial row-gap is 'normal' 2: FAIL
    Negative row-gap is invalid: FAIL
    Resolution row-gap is invalid: FAIL
    Time row-gap is invalid: FAIL
    row-gap accepts calc(): FAIL
    row-gap accepts em: FAIL
    row-gap accepts percentage: FAIL
    row-gap accepts pixels: FAIL
    row-gap is inheritable: FAIL
    row-gap with multiple values is invalid: FAIL
/css/css-align/gaps/row-gap-animation-001.html
    row-gap is interpolable: FAIL
/css/css-align/gaps/row-gap-animation-002.html
    row-gap: normal is not interpolable: FAIL
/css/css-align/gaps/row-gap-animation-003.html
    Default row-gap is not interpolable: FAIL
/css/css-align/gaps/row-gap-parsing-001.html
    'max-content' row-gap is invalid: FAIL
    'none' row-gap is invalid: FAIL
    Angle row-gap is invalid: FAIL
    Default row-gap is 'normal': FAIL
    Initial inherited row-gap is 'normal': FAIL
    Initial row-gap is 'normal': FAIL
    Initial row-gap is 'normal' 2: FAIL
    Negative row-gap is invalid: FAIL
    Resolution row-gap is invalid: FAIL
    Time row-gap is invalid: FAIL
    row-gap accepts calc(): FAIL
    row-gap accepts em: FAIL
    row-gap accepts percentage: FAIL
    row-gap accepts pixels: FAIL
    row-gap is inheritable: FAIL
    row-gap with multiple values is invalid: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7f5e7efc269
[wpt PR 9227]- Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/a7f5e7efc269
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.