Closed Bug 1441260 Opened 2 years ago Closed 2 years ago

Unify interface for setting RTP headers for Audio and Video conduits

Categories

(Core :: WebRTC, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: ng, Assigned: ng)

Details

Attachments

(1 file)

Audio and Video conduits use different interfaces for setting the RTP extmaps.  This should be unified ahead of the webrtc 64 merge to reduce merge pain.
Attachment #8954266 - Flags: review?(mfroman)
Attachment #8954266 - Flags: review?(dminor)
Comment on attachment 8954266 [details]
Bug 1441260 - unify API for setting extmaps in AudioConduit

https://reviewboard.mozilla.org/r/223412/#review230022

lgtm, thanks for cleaning this up.

::: media/webrtc/signaling/src/media-conduit/MediaConduitInterface.h:37
(Diff revision 5)
>  class VideoFrame;
>  }
>  
>  namespace mozilla {
>  
> +enum class MediaSessionConduitLocalDirection : int {

nit: I don't think it's necessary to specify the type here.
Attachment #8954266 - Flags: review?(dminor) → review+
Comment on attachment 8954266 [details]
Bug 1441260 - unify API for setting extmaps in AudioConduit

https://reviewboard.mozilla.org/r/223412/#review230022

> nit: I don't think it's necessary to specify the type here.

This has to be done to allow forward declaration unfortunately.
Comment on attachment 8954266 [details]
Bug 1441260 - unify API for setting extmaps in AudioConduit

https://reviewboard.mozilla.org/r/223412/#review230678

Like a breath of fresh air!
Attachment #8954266 - Flags: review?(mfroman) → review+
Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/fa1869480dd5
unify API for setting extmaps in AudioConduit r=dminor,mjf
https://hg.mozilla.org/mozilla-central/rev/fa1869480dd5
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.