Closed
Bug 1441260
Opened 6 years ago
Closed 6 years ago
Unify interface for setting RTP headers for Audio and Video conduits
Categories
(Core :: WebRTC, enhancement, P3)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: ng, Assigned: ng)
Details
Attachments
(1 file)
Audio and Video conduits use different interfaces for setting the RTP extmaps. This should be unified ahead of the webrtc 64 merge to reduce merge pain.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•6 years ago
|
Attachment #8954266 -
Flags: review?(mfroman)
Attachment #8954266 -
Flags: review?(dminor)
|
||
Comment 6•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8954266 [details] Bug 1441260 - unify API for setting extmaps in AudioConduit https://reviewboard.mozilla.org/r/223412/#review230022 lgtm, thanks for cleaning this up. ::: media/webrtc/signaling/src/media-conduit/MediaConduitInterface.h:37 (Diff revision 5) > class VideoFrame; > } > > namespace mozilla { > > +enum class MediaSessionConduitLocalDirection : int { nit: I don't think it's necessary to specify the type here.
Attachment #8954266 -
Flags: review?(dminor) → review+
|
|
Assignee | |
Comment 7•6 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8954266 [details] Bug 1441260 - unify API for setting extmaps in AudioConduit https://reviewboard.mozilla.org/r/223412/#review230022 > nit: I don't think it's necessary to specify the type here. This has to be done to allow forward declaration unfortunately.
| Comment hidden (mozreview-request) |
|
||
Comment 9•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8954266 [details] Bug 1441260 - unify API for setting extmaps in AudioConduit https://reviewboard.mozilla.org/r/223412/#review230678 Like a breath of fresh air!
Attachment #8954266 -
Flags: review?(mfroman) → review+
|
||
Comment 10•6 years ago
|
||
Pushed by na-g@nostrum.com: https://hg.mozilla.org/integration/autoland/rev/fa1869480dd5 unify API for setting extmaps in AudioConduit r=dminor,mjf
|
||
Comment 11•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fa1869480dd5
You need to log in
before you can comment on or make changes to this bug.
Description
•