1441275 - Fix --enable-js-shell in the tup backend

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Michael Shal [:mshal]]

This flag isn't enabled by default, but is turned on for most automation builds by mozconfig.common. We should make it build correctly with the tup backend.

Comment 1

[Michael Shal [:mshal]]

Attachment: Bug 1441275 - ignore js/src/shell OBJDIR_FILES in the tup backend;

Without linking support in the tup backend, we don't produce a js
binary, so we can't copy it via OBJDIR_FILES yet.

Review commit: https://reviewboard.mozilla.org/r/223346/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223346/

Comment 2

[Michael Shal [:mshal]]

Attachment: Bug 1441275 - list outputs of embedjs.py correctly;

embedjs.py produces two outputs, so we should list them both in the
GENERATED_FILES rule. This avoids unspecified output errors when using
the tup backend.

Review commit: https://reviewboard.mozilla.org/r/223348/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223348/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8954187 [details]
Bug 1441275 - ignore js/src/shell OBJDIR_FILES in the tup backend;

https://reviewboard.mozilla.org/r/223346/#review229448

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8954188 [details]
Bug 1441275 - list outputs of embedjs.py correctly;

https://reviewboard.mozilla.org/r/223348/#review229450

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb14b807a77d
ignore js/src/shell OBJDIR_FILES in the tup backend; r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/7e9df457d4b7
list outputs of embedjs.py correctly; r=chmanchester

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/bb14b807a77d
https://hg.mozilla.org/mozilla-central/rev/7e9df457d4b7