Closed Bug 1441331 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 9405 - custom-elements: Fix a bug that HTML parser didn't set custom element state correctly for unknown "is" attribute value.

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: wptsync, Unassigned)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 9405 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/9405
Details from upstream follow.

Kent Tamura wrote:
>  custom-elements: Fix a bug that HTML parser didn't set custom element state correctly for unknown "is" attribute value.
>  
>  In HTML parser, if custom element definition is not found and the
>  element local name is invalid for custom element name, custom element
>  state of the element was set to "Uncustomized", which won't be upgraded.
>  
>  It should be "Undefined" if "is" attribute exists.
>  
>  Also, CustomElementRegistry::AddCandidate() didn't pick up a correct
>  name for customized built-in candidates.
>  
>  A Blink layout test for :defined is upstreamed to WPT.
>  
>  Bug: 736967
>  Change-Id: I583073eabc4ac276c6990161516c7b289905909b
>  Reviewed-on: https://chromium-review.googlesource.com/903423
>  Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
>  Commit-Queue: Kent Tamura <tkent@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#534621}
>  
>  
>
Component: web-platform-tests → DOM
Product: Testing → Core
Ran 1 tests and 32 subtests
OK     : 1
FAIL   : 32

New tests that have failures or other problems:
/custom-elements/pseudo-class-defined.html
    <a-a> should not be :defined: FAIL
    <abbr is=my-abbr> should not be :defined: FAIL
    <div> should be :defined: FAIL
    <font-face> should be :defined: FAIL
    Upgraded createElement("a-a") should be :defined: FAIL
    Upgraded createElement("abbr", { is: "my-abbr" }) should be :defined: FAIL
    Upgraded createElementNS("http://www.w3.org/1999/xhtml", "a-a") should be :defined: FAIL
    Upgraded createElementNS("http://www.w3.org/1999/xhtml", "abbr", { is: "my-abbr" }) should be :defined: FAIL
    Without browsing context: createElement("a-a") should not be :defined: FAIL
    Without browsing context: createElement("abbr", { is: "my-abbr" }) should not be :defined: FAIL
    Without browsing context: createElement("div") should be :defined: FAIL
    Without browsing context: createElement("font-face") should be :defined: FAIL
    Without browsing context: createElementNS("http://www.w3.org/1999/xhtml", "a-a") should not be :defined: FAIL
    Without browsing context: createElementNS("http://www.w3.org/1999/xhtml", "abbr", { is: "my-abbr" }) should not be :defined: FAIL
    Without browsing context: createElementNS("http://www.w3.org/1999/xhtml", "div") should be :defined: FAIL
    Without browsing context: createElementNS("http://www.w3.org/1999/xhtml", "font-face") should be :defined: FAIL
    Without browsing context: createElementNS("http://www.w3.org/2000/svg", "a-a") should be :defined: FAIL
    Without browsing context: createElementNS("http://www.w3.org/2000/svg", "abbr", { is: "my-abbr" }) should be :defined: FAIL
    Without browsing context: createElementNS("http://www.w3.org/2000/svg", "div") should be :defined: FAIL
    Without browsing context: createElementNS("http://www.w3.org/2000/svg", "font-face") should be :defined: FAIL
    createElement("a-a") should not be :defined: FAIL
    createElement("abbr", { is: "my-abbr" }) should not be :defined: FAIL
    createElement("div") should be :defined: FAIL
    createElement("font-face") should be :defined: FAIL
    createElementNS("http://www.w3.org/1999/xhtml", "a-a") should not be :defined: FAIL
    createElementNS("http://www.w3.org/1999/xhtml", "abbr", { is: "my-abbr" }) should not be :defined: FAIL
    createElementNS("http://www.w3.org/1999/xhtml", "div") should be :defined: FAIL
    createElementNS("http://www.w3.org/1999/xhtml", "font-face") should be :defined: FAIL
    createElementNS("http://www.w3.org/2000/svg", "a-a") should be :defined: FAIL
    createElementNS("http://www.w3.org/2000/svg", "abbr", { is: "my-abbr" }) should be :defined: FAIL
    createElementNS("http://www.w3.org/2000/svg", "div") should be :defined: FAIL
    createElementNS("http://www.w3.org/2000/svg", "font-face") should be :defined: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/82ca7fbcb494
[wpt PR 9405]- Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/82ca7fbcb494
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.