1441335 - Base allocator commit is under-evaluated

Status: RESOLVED FIXED

(Core :: Memory Allocator, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1441335 - Fix base allocator commit evaluation.

Base allocator commit stats were added in bug 515556, along other commit
stats, but they have actually been wrong since then: the committed count
is updated with the difference between pbase_next_addr and
base_next_decommitted *after* the latter is set to the former, making
the difference always 0.

Review commit: https://reviewboard.mozilla.org/r/223360/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223360/

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 8954202 [details]
Bug 1441335 - Fix base allocator commit evaluation.

https://reviewboard.mozilla.org/r/223360/#review229454

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e1c789da3fc
Fix base allocator commit evaluation. r=njn

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/4e1c789da3fc