1441365 - Add keyboard shortcut for Pocket

Status: UNCONFIRMED

(Firefox :: Keyboard Navigation, enhancement, P5)

Description

[Hugo Romano]

Description
Please add a keyboard shortcut that saves the active tab to Pocket.

Desired Shortcuts
• Mac: Command + E
• Windows & Linux: Ctrl + Alt + D

Additional Details
1. The "page saved" door hanger should be triggered after the page is saved, same behavior as clicking on the Pocket button manually. Call the save event from pktApi.jsm.
2. If users are logged-out, pressing the shortcut key should trigger the logged-out door-hanger from the Pocket button. Same behavior as clicking on the Pocket button while being logged out. 
3. If users are in a page that doesn't have page action buttons (e.g. new tab page), pressing the keyboard shortcut should do nothing. 
4. Hovering over the Pocket button in the URL bar should display "Save to Pocket (key combo)" as helper text. 

Full Spec
• See: https://docs.google.com/document/d/1d1U0y6Pws40fnpapQ8kC0CgdugbDf1f7v6kzaLJHUgQ/edit#heading=h.nqtujv4g527h

Comment 1

[Dão Gottwald [:dao]]

Pretty sure Ctrl+Alt combos are intended for OS-level shortcuts on Windows.

Comment 2

[Hugo Romano]

Thanks for looking into this. Open to suggestions if we can find a better shortcut. Please see the document I linked to for other options I've explored.

It looks like Ctrl + Alt + D isn't assigned to anything on Windows. Additionally, Firefox already uses a few Ctrl+Alt shortcuts: https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly e.g. for the PDF viewer and to toggle the reader mode.

Comment 3

[Dão Gottwald [:dao]]

(In reply to Hugo Romano from comment #2)
> Thanks for looking into this. Open to suggestions if we can find a better
> shortcut. Please see the document I linked to for other options I've
> explored.
> 
> It looks like Ctrl + Alt + D isn't assigned to anything on Windows.
> Additionally, Firefox already uses a few Ctrl+Alt shortcuts:
> https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-
> tasks-quickly e.g. for the PDF viewer and to toggle the reader mode.

Reader mode explicitly avoids using Ctrl+Alt on Windows. It uses F9 instead. The PDF viewer may be an outlier but that's not really a good reason to continue that bad pattern here. (The PDF viewer is in the content area and doesn't need application-wide shortcuts anyway. It should probably use Alt+Shift like all web content: https://developer.mozilla.org/de/docs/Web/HTML/Global_attributes/accesskey)

Comment 4

[Roman Lopez]

Hello, I would like to work on this. I am new to Open Source, but would like to start with this bug. Can one of the mentors guide me in how to get started?

Comment 5

[Makenzie]

I'm an outreachy applicant interested in working on this. I submitted a request for the google doc. Thanks!

Comment 6

[mohsinbalty]

I'm an outreachy applicant interested in working on this. I submitted a request for the google doc. Thanks!

Comment 7

[Mike Kaply [:mkaply]]

Attachment: Pocket FX Keyboard Shortcut Spec.pdf

PDF of spec

Comment 8

[Blessing Peters]

Hello, I am outreachy applicant and I am interested in working on this bug. I have submitted a request for the google doc. Thank you

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit BugBot documentation.