Closed Bug 1441558 Opened 4 years ago Closed 4 years ago

MinGW debug build does not run with the Poison IO Interposer

Categories

(Core :: XPCOM, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tor])

Attachments

(1 file)

The debug build crashes on run with this; whatever we're doing here I don' think MinGW can handle.
I have zero problems with disabling the IO poisoning stuff on mingw.
Comment on attachment 8954419 [details]
Bug 1441558 Do not compile the Poison IO Interposer on MinGW

https://reviewboard.mozilla.org/r/223510/#review229600

::: xpcom/build/moz.build:32
(Diff revision 1)
>  
>  if CONFIG['OS_ARCH'] == 'WINNT':
>      EXPORTS += ['nsWindowsDllInterceptor.h']
>      EXPORTS.mozilla += ['perfprobe.h']
> +    SOURCES += ['perfprobe.cpp']
> +    if CONFIG['CC_TYPE'] != 'gcc':

I was going to suggest `CONFIG['CC_TYPE'] == 'msvc'`, but I guess we want the interposer for clang-cl builds, since those are more msvc-ish.  OK, the check as written makes sense.
Attachment #8954419 - Flags: review?(nfroyd) → review+
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c6ddf756d2a
Do not compile the Poison IO Interposer on MinGW r=froydnj
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8c6ddf756d2a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.