Closed Bug 1441558 Opened 4 years ago Closed 4 years ago
GW debug build does not run with the Poison IO Interposer
59 bytes, text/x-review-board-request
The debug build crashes on run with this; whatever we're doing here I don' think MinGW can handle.
I have zero problems with disabling the IO poisoning stuff on mingw.
Comment on attachment 8954419 [details] Bug 1441558 Do not compile the Poison IO Interposer on MinGW https://reviewboard.mozilla.org/r/223510/#review229600 ::: xpcom/build/moz.build:32 (Diff revision 1) > > if CONFIG['OS_ARCH'] == 'WINNT': > EXPORTS += ['nsWindowsDllInterceptor.h'] > EXPORTS.mozilla += ['perfprobe.h'] > + SOURCES += ['perfprobe.cpp'] > + if CONFIG['CC_TYPE'] != 'gcc': I was going to suggest `CONFIG['CC_TYPE'] == 'msvc'`, but I guess we want the interposer for clang-cl builds, since those are more msvc-ish. OK, the check as written makes sense.
Attachment #8954419 - Flags: review?(nfroyd) → review+
4 years ago
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/8c6ddf756d2a Do not compile the Poison IO Interposer on MinGW r=froydnj
You need to log in before you can comment on or make changes to this bug.