Closed
Bug 1441584
Opened 4 years ago
Closed 4 years ago
sprinkle final on various URL and URL mutator classes
Categories
(Core :: Networking, enhancement, P2)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
(Whiteboard: [necko-triaged])
Attachments
(2 files)
6.22 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
3.26 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
![]() |
Assignee | |
Comment 1•4 years ago
|
||
For documentation purposes and to assist the compiler.
Attachment #8954415 -
Flags: review?(valentin.gosu)
![]() |
Assignee | |
Comment 2•4 years ago
|
||
Attachment #8954417 -
Flags: review?(valentin.gosu)
Comment on attachment 8954415 [details] [diff] [review] part 1 - declare inner URI Mutator classes final Review of attachment 8954415 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8954415 -
Flags: review?(valentin.gosu) → review+
Comment on attachment 8954417 [details] [diff] [review] part 2 - declare some URI classes final Review of attachment 8954417 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/file/nsHostObjectURI.h @@ +24,5 @@ > * These URIs refer to host objects: Blobs, with scheme "blob", > * MediaStreams, with scheme "mediastream", and MediaSources, with scheme > * "mediasource". > */ > +class nsHostObjectURI final : public mozilla::net::nsSimpleURI Since we're here let's move the inherited interfaces to the next line: class nsHostObjectURI final : public mozilla::net::nsSimpleURI , ... ::: dom/jsurl/nsJSProtocolHandler.h @@ +60,5 @@ > nsCOMPtr<nsITextToSubURI> mTextToSubURI; > }; > > > +class nsJSURI final : public mozilla::net::nsSimpleURI same. ::: netwerk/protocol/about/nsAboutProtocolHandler.h @@ +52,5 @@ > }; > > > // Class to allow us to propagate the base URI to about:blank correctly > +class nsNestedAboutURI final : public nsSimpleNestedURI { same, and move the { to the next line
Attachment #8954417 -
Flags: review?(valentin.gosu) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bd2ddd101d71 part 1 - declare inner URI Mutator classes final; r=valentin https://hg.mozilla.org/integration/mozilla-inbound/rev/24cfdecfcc93 part 2 - declare some URI classes final; r=valentin
![]() |
||
Comment 6•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bd2ddd101d71 https://hg.mozilla.org/mozilla-central/rev/24cfdecfcc93
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•