1441584 - sprinkle final on various URL and URL mutator classes

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: part 1 - declare inner URI Mutator classes final

For documentation purposes and to assist the compiler.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: part 2 - declare some URI classes final

Comment 3

[Valentin Gosu [:valentin] (he/him) <<Parental leave March 1 - August 1>>]

Comment on attachment 8954415 [details] [diff] [review]
part 1 - declare inner URI Mutator classes final

Review of attachment 8954415 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[Valentin Gosu [:valentin] (he/him) <<Parental leave March 1 - August 1>>]

Comment on attachment 8954417 [details] [diff] [review]
part 2 - declare some URI classes final

Review of attachment 8954417 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/file/nsHostObjectURI.h
@@ +24,5 @@
>   * These URIs refer to host objects: Blobs, with scheme "blob",
>   * MediaStreams, with scheme "mediastream", and MediaSources, with scheme
>   * "mediasource".
>   */
> +class nsHostObjectURI final : public mozilla::net::nsSimpleURI

Since we're here let's move the inherited interfaces to the next line:
class nsHostObjectURI final
    : public mozilla::net::nsSimpleURI
    , ...

::: dom/jsurl/nsJSProtocolHandler.h
@@ +60,5 @@
>      nsCOMPtr<nsITextToSubURI>  mTextToSubURI;
>  };
>  
>  
> +class nsJSURI final : public mozilla::net::nsSimpleURI

same.

::: netwerk/protocol/about/nsAboutProtocolHandler.h
@@ +52,5 @@
>  };
>  
>  
>  // Class to allow us to propagate the base URI to about:blank correctly
> +class nsNestedAboutURI final : public nsSimpleNestedURI {

same, and move the { to the next line

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd2ddd101d71
part 1 - declare inner URI Mutator classes final; r=valentin
https://hg.mozilla.org/integration/mozilla-inbound/rev/24cfdecfcc93
part 2 - declare some URI classes final; r=valentin

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bd2ddd101d71
https://hg.mozilla.org/mozilla-central/rev/24cfdecfcc93