1441627 - Restyle the Gloda results page

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Richard Marti (:Paenglab)]

The actual Gloda results page doesn't look like the other TB UI. It looks more like a web page but with more Mac centric colours.

We should try to make the look more like a system integrated page.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Glodarestyle.patch

Aceman and Jörg, what do you think about this aproach? I'm using more system colours and simplified some rules. With using CSS variables we can also get rid of the hard coded colours in glodaFacetVis.js.

Aceman, I haven't made a border between the left and right part as it could look like a splitter which could the user try to move.

Comment 2

[:aceman]

Comment on attachment 8954470 [details] [diff] [review]
Glodarestyle.patch

Review of attachment 8954470 [details] [diff] [review]:
-----------------------------------------------------------------

Less of rounded ugliness and instead of hardcoded rgb values you use variables that can be set in platform dependent css?
Count me in:) But I only tested Linux.

Maybe you could also make the "List all N" more button-like?

Comment 3

[Jorg K (CEST = GMT+2)]

I don't like the new hover behaviour on the right. When you're not hovering on the right, the items on the right are separated by lines. Fine. If you hover the 2nd, 3rd, 4th, etc. item, it gets a solid border, fine, but the separator line above is still drawn. That doesn't look good. You want a screenshot? Looks like there're shouldn't be a margin between the items, so if you draw the box, it gets drawn on top of the separator.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Glodarestyle.patch

aceman, now with normal buttons.
Jörg, is this better now?

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8955789 [details] [diff] [review]
Glodarestyle.patch

(In reply to Richard Marti (:Paenglab) from comment #4)
> Jörg, is this better now?
Yep, nice. You could consider making the hovered border a bit thinker than the separator lines.

Comment 6

[:aceman]

Comment on attachment 8955789 [details] [diff] [review]
Glodarestyle.patch

Review of attachment 8955789 [details] [diff] [review]:
-----------------------------------------------------------------

Better, thanks.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: Glodarestyle.patch

Added a box-shadow to make the hovered message border a bit thicker.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dd23a08fa231
Restyle the Gloda results page. f=jorgk, r=aceman

Comment 9

[Thomas D. (:thomas8)]

Pls CC me on bugs like these...