1441646 - Click on a error location does not navigate the user to the debugger

Status: NEW

(DevTools :: Shared Components, defect)

Description

[Armen [:armenzg]]

STR:
* checkout this project: https://github.com/mozilla-frontend-infra/perf-goggles
* switch to the 'devtools_issue' branch
* yarn
* yarn start
* Load localhost:5000 and look at the errors in the console

This error is shown in Nightly dev tools (the link to the source code is broken):
> TypeError: this.stat is undefined    index.js%20line%202305%20%3E%20eval:48:1

while Chrome's dev tools show it as (navigable link + context):
> Uncaught TypeError: Cannot read property 'length' of undefined  App.jsx?be64:12
>    at ProxyComponent.render (App.jsx?be64:12)
>    at ProxyComponent.render (createPrototypeProxy.js?6ea8:44)
>    at ProxyComponent.proxiedRender (react-hot-loader.development.js?280f:540)
>    at finishClassComponent (react-dom.development.js?cada:7873)
>    at updateClassComponent (react-dom.development.js?cada:7850)
>    at beginWork (react-dom.development.js?cada:8225)
>    at performUnitOfWork (react-dom.development.js?cada:10224)
>    at slowWorkLoopThatChecksForFailedWork (react-dom.development.js?cada:10310)
>    at workLoop (react-dom.development.js?cada:10278)
>    at HTMLUnknownElement.callCallback (react-dom.development.js?cada:542)

Notice Chrome gives the full context, it refers to App.jsx (rather than index.js) and it takes you to the source code if you click on it.

Comment 1

[Armen [:armenzg]]

Attachment: Screenshot of Nightly side by side with Chrome (a different error though than the one on the referred repo)

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

So there multiple things here:
1. The thrown error (from index.js%20line%202305%20%3E%20eval:48:1)  does not have an actionable location
2. Logged error objects (from react-hot-loader.development.js:95) don't have actionable frames

2. is tracked at https://github.com/devtools-html/devtools-core/projects/3 (and note that you can expand the stacktrace from 1. , which will give you App.jsx)

Let's focus on 1. for this bug.