Closed Bug 1441668 Opened 4 years ago Closed 2 years ago

editMenuOverlay.xul removal

Categories

(SeaMonkey :: General, enhancement)

enhancement
Not set
normal

Tracking

(seamonkey2.53 unaffected, seamonkey2.57esr affected)

RESOLVED FIXED
seamonkey 2.74
Tracking Status
seamonkey2.53 --- unaffected
seamonkey2.57esr --- affected

People

(Reporter: bdahl, Assigned: frg)

References

(Blocks 3 open bugs)

Details

Attachments

(2 files, 5 obsolete files)

A heads up...over in bug 1439766 I will be removing editMenuOverlay.xul.
Blocks: 1444685
Might work but need to check if we need to move individual keys. Really bad compared to just including the overlay but can't be helped. If someone else wants to finish it be my guest.
Rebased 2.57 wip patch
Attachment #8967556 - Attachment is obsolete: true
Rebased c-c wip patch
Assignee: nobody → frgrahl
Attachment #8985853 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attached patch 1441668-editmenuoverlay-cc.patch (obsolete) — Splinter Review

comm-central version

Attachment #8985854 - Attachment is obsolete: true
Blocks: 1611647
Comment on attachment 9140551 [details] [diff] [review]
1441668-editmenuoverlay-257.patch

The only place that still seems to need editMenuOverlay.dtd is placesOverlay.xul, so it can be removed from the rest of the code:
>+++ b/suite/components/console/content/console.xul
> <!DOCTYPE window [
>   <!ENTITY % console SYSTEM "chrome://communicator/locale/console/console.dtd"> %console;
>+  <!ENTITY % editMenuDTD SYSTEM "chrome://global/locale/editMenuOverlay.dtd"> %editMenuDTD;
> ]>
As there will be only one dtd file, just turn this into a single line <!DOCTYPE window SYSTEM...

>+++ b/suite/components/downloads/content/downloadmanager.xul
> <!DOCTYPE window [
> <!ENTITY % downloadsDTD SYSTEM "chrome://communicator/locale/downloads/downloadmanager.dtd">
> %downloadsDTD;
> <!ENTITY % editMenuOverlayDTD SYSTEM "chrome://global/locale/editMenuOverlay.dtd">
> %editMenuOverlayDTD;
These two lines can be removed.

>+++ b/suite/components/places/content/history-panel.xul
> <!DOCTYPE page [
> <!ENTITY % placesDTD SYSTEM "chrome://communicator/locale/places/places.dtd">
> %placesDTD;
>+<!ENTITY % editMenuOverlayDTD SYSTEM "chrome://global/locale/editMenuOverlay.dtd">
>+ %editMenuOverlayDTD;
> ]>
As there will be only one dtd file, just turn this into a single line <!DOCTYPE page SYSTEM...

>+++ b/suite/components/places/content/places.xul
> <!DOCTYPE window [
> <!ENTITY % placesDTD SYSTEM "chrome://communicator/locale/places/places.dtd">
> %placesDTD;
> <!ENTITY % editMenuOverlayDTD SYSTEM "chrome://global/locale/editMenuOverlay.dtd">
> %editMenuOverlayDTD;
These two lines can be removed.

r/a=me with those addressed.
Attachment #9140551 - Flags: review+
Attachment #9140551 - Flags: approval-comm-esr60+
Comment on attachment 9140553 [details] [diff] [review]
1441668-editmenuoverlay-cc.patch

Same comments as for the other patch, r =me with those addressed.
Attachment #9140553 - Flags: review+

Updated comm-central patch r+ from IanN retained. Additional fixes as discussed via irc.

Attachment #9140553 - Attachment is obsolete: true
Attachment #9140828 - Flags: review+

Updated 2.57 patch. r/a+ from IanN retained. Additional fixes as discussed via irc.

Attachment #9140551 - Attachment is obsolete: true
Attachment #9140829 - Flags: review+
Attachment #9140829 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/e0aed4844492
Replace editMenuOverlay.xul in SeaMonkey with preprocessed includes. r=IanN

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey 2.74
Version: unspecified → Trunk
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/7e0a7e7cf046
Follow-up fix build bustage. r=frg
You need to log in before you can comment on or make changes to this bug.