1441729 - Remove aTextIsSignificant param from nsStyleUtil::IsSignificantChild and its friends

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Xidorn Quan [:xidorn] UTC+11]

All callsites of this function pass true for it, so it makes no sense to keep it at all.

Reading back the history, the third param aWhitespaceIsSignificant was introduced in bug 157395. From the code, it can be seen that at that age, IsSignificantChild is also used by :{only,first,last}-child pseudo-class selectors, which passes false for aTextIsSignificant. [1]

We know that we have been using some more complicated mechanism for the tree-structural pseudo-classes, and aTextIsSignificant param lost its usefulness since then.

So we can remove it now.


[1] https://github.com/mozilla/gecko-dev/commit/6de447be6a438f24d5209e7296908876a200cd53

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

Given this history, we can probably even rename IsSignificantChild to something like IsNodeEmpty or something like that, and probably have an enum for that...

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Bug 1441729 - Remove aTextIsSignificant param from nsStyleUtil::IsSignificantChild and its friends.

Review commit: https://reviewboard.mozilla.org/r/223702/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223702/

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8954628 [details]
Bug 1441729 - Remove aTextIsSignificant param from nsStyleUtil::IsSignificantChild and its friends.

https://reviewboard.mozilla.org/r/223702/#review229804

Nice catch :)

Comment 4

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8954628 [details]
Bug 1441729 - Remove aTextIsSignificant param from nsStyleUtil::IsSignificantChild and its friends.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/223702/diff/1-2/

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8954628 [details]
Bug 1441729 - Remove aTextIsSignificant param from nsStyleUtil::IsSignificantChild and its friends.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/223702/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1fcc8099f2d9
Remove aTextIsSignificant param from nsStyleUtil::IsSignificantChild and its friends. r=emilio

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1fcc8099f2d9