Status

()

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: njn, Assigned: njn)

Tracking

(Blocks 1 bug)

Trunk
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(5 attachments)

Assignee

Description

a year ago
CallbackNode is inefficiently packed, which wastes memory.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 6

a year ago
mozreview-review
Comment on attachment 8954663 [details]
Bug 1441754 - clang-format some Preferences.cpp code that needs it.

https://reviewboard.mozilla.org/r/223766/#review230534
Attachment #8954663 - Flags: review?(mh+mozilla) → review+

Comment 7

a year ago
mozreview-review
Comment on attachment 8954664 [details]
Bug 1441754 - Split measurements of pref callbacks in two.

https://reviewboard.mozilla.org/r/223768/#review230536
Attachment #8954664 - Flags: review?(mh+mozilla) → review+

Comment 8

a year ago
mozreview-review
Comment on attachment 8954665 [details]
Bug 1441754 - Privatize CallbackNode's field.

https://reviewboard.mozilla.org/r/223770/#review230538
Attachment #8954665 - Flags: review?(mh+mozilla) → review+

Comment 9

a year ago
mozreview-review
Comment on attachment 8954666 [details]
Bug 1441754 - Shrink CallbackNode by combining mMatchKind and mNext into a tagged pointer.

https://reviewboard.mozilla.org/r/223772/#review230540
Attachment #8954666 - Flags: review?(mh+mozilla) → review+

Comment 10

a year ago
mozreview-review
Comment on attachment 8954667 [details]
Bug 1441754 - Use MOZ_ASSERT instead of NS_ASSERTION and NS_PRECONDITION in Preferences.cpp.

https://reviewboard.mozilla.org/r/223774/#review230542
Attachment #8954667 - Flags: review?(mh+mozilla) → review+
Assignee

Comment 11

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a6b832ce2521677f35b380245a621c2d46eb03c
Bug 1441754 - clang-format some Preferences.cpp code that needs it. r=glandium

https://hg.mozilla.org/integration/mozilla-inbound/rev/17fe71b2e622c2ae4bfcc963156ddc8815f40dd1
Bug 1441754 - Split measurements of pref callbacks in two. r=glandium

https://hg.mozilla.org/integration/mozilla-inbound/rev/13e0252c67c9caeb7fa73ae5b2e16080c84cb728
Bug 1441754 - Privatize CallbackNode's field. r=glandium

https://hg.mozilla.org/integration/mozilla-inbound/rev/e6680fcb17a0392208b7413a214a662f8b8ca284
Bug 1441754 - Shrink CallbackNode by combining mMatchKind and mNext into a tagged pointer. r=glandium

https://hg.mozilla.org/integration/mozilla-inbound/rev/76a740cc4454f92c44b10e63abcc3d68daf8ee06
Bug 1441754 - Use MOZ_ASSERT instead of NS_ASSERTION and NS_PRECONDITION in Preferences.cpp. r=glandium
Assignee: nobody → n.nethercote
You need to log in before you can comment on or make changes to this bug.